Fix Pex locking for source requirements. #2750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, locking VCS requirements would fail for projects with non-normalized project names, e.g.: PySocks vs its normalized form of pysocks. Additionally, locking would fail when the requirements were specified at least in part via requirements files (`-r` / `--requirements`) and there was either a local project or a VCS requirement contained in the requirements files.
Get rid of `os.chdir` fixture which was inherently unsafe and also fix the Pex build backend to not ask setuptools to help calculate extra build requirements - we know the answers for these ourselves.
Allow for project names containing dash.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, locking VCS requirements would fail for projects with
non-normalized project names, e.g.: PySocks vs its normalized form of
pysocks.
Additionally, locking would fail when the requirements were specified
at least in part via requirements files (
-r/--requirements) andthere was either a local project or a VCS requirement contained in the
requirements files.