Fixed merge command to show proper information after merge #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterrehm
added a commit
that referenced
this pull request
Dec 16, 2014
…terrehm) Discussion ---------- The merge command had an issue detecting the merge status since it relied on another call to the github api. Most likely to the way we merge the commits the merge status is updated slightly later. The check now relies on the fact that all commands will be executed successfully. Tickets: - none Commits ------- - a0124f8 merge command detected merge status incorrectly. (peterrehm)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The merge command had an issue detecting the merge status since it relied on another
call to the github api. Most likely to the way we merge the commits the merge status is
updated slightly later.
The check now relies on the fact that all commands will be executed successfully.
Tickets: