(trunk) PS-9647: MySQL Perf Improvements (deque) #5642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| assert_not_invalidated(); | ||
| return Iterator{m_deque, m_physical_idx + offset}; | ||
| } | ||
| bool empty() const { return list_.empty(); } |
There was a problem hiding this comment.
function empty should be marked [[nodiscard]]
Suggested change
| bool empty() const { return list_.empty(); } | |
| [[nodiscard]] bool empty() const { return list_.empty(); } |
| assert_not_invalidated(); | ||
| return Iterator{m_deque, m_physical_idx - offset}; | ||
| } | ||
| size_t size() const { return list_.size(); } |
There was a problem hiding this comment.
function size should be marked [[nodiscard]]
Suggested change
| size_t size() const { return list_.size(); } | |
| [[nodiscard]] size_t size() const { return list_.size(); } |
https://perconadev.atlassian.net/browse/PS-9647 This patch uses list instead of deque for memory efficiency reasons, primarily to optimize operations like bulk insert
163aac6 to
420e411
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/PS-9647
This patch uses list instead of deque for memory efficiency reasons, primarily to optimize operations like bulk insert
Cherry pick of 7509e14