(8.4) PS-9647: MySQL Perf Improvements (deque) #5640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2a39e84 to
ac24254
Compare
| @@ -7107,11 +7107,12 @@ static uint get_semi_join_select_list_index(Item_field *item_field) { | |||
| if (emb_sj_nest && emb_sj_nest->is_sj_or_aj_nest()) { | |||
| const mem_root_deque<Item *> &items = | |||
| emb_sj_nest->nested_join->sj_inner_exprs; | |||
| for (size_t i = 0; i < items.size(); i++) { | |||
| const Item *sel_item = items[i]; | |||
| size_t i = 0; | |||
There was a problem hiding this comment.
variable name i is too short, expected at least 2 characters
https://perconadev.atlassian.net/browse/PS-9647 This patch uses list instead of deque for memory efficiency reasons, primarily to optimize operations like bulk insert
ac24254 to
0ec7aa3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/PS-9647
This patch uses list instead of deque for memory efficiency reasons, primarily to optimize operations like bulk insert
Cherry pick of 7509e14