-
Notifications
You must be signed in to change notification settings - Fork 2
Release 0.15.0 #425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.15.0 #425
Conversation
…sample table to filter out ph_id, and set default schema dropdown in new pep modal to databio/pep-2.1.0
# Conflicts: # pephub/_version.py
bring in task def changes
…cle_stage, maintainers, contributors, release_notes
Schemas 2.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR bumps the release to 0.15.0 and introduces new schema functionality including records, versions, and tags. Key changes include a new key-value input component, extensive updates to the schemas API with modified payloads and endpoints for schema versions, and adjustments to various namespace and project routes across both the API and UI.
Reviewed Changes
Copilot reviewed 58 out of 62 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
web/src/components/forms/components/key-value-input.tsx | New component enabling tag-based key/value input. |
web/src/api/schemas.ts | Updates to schema types and endpoints (including schema versioning) with updated query parameters and payload structure. |
pephub/helpers.py | Addition of a new function to download JSON content. |
pephub/routers/api/v1/namespace.py, pephub/routers/models.py, web/src/api/namespace.ts | Adjustments to namespace information routes and modeling, aligning with new schema functionality. |
pephub/dependencies.py, pephub/routers/api/v1/project.py, pephub/main.py | Various routing, dependency, and version updates across the codebase. |
web/src/components/forms/components/schemas-databio-dropdown.tsx, combined-error-message.tsx, namespace-grid.tsx, namespace-long-row.tsx | Modifications to utilize the new schema naming conventions and improve UI consistency. |
.github/workflows/black.yml | Workflow update to newer action versions. |
pephub/_version.py | Version bump to 0.15.0_dev0. |
Files not reviewed (4)
- deployment/task_defs/dev.json: Language not supported
- deployment/task_defs/primary.json: Language not supported
- launch_docker.sh: Language not supported
- requirements/requirements-all.txt: Language not supported
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Deploying pephub-ui with
|
Latest commit: |
586555c
|
Status: | ✅ Deploy successful! |
Preview URL: | https://3aa1e995.pephub.pages.dev |
Branch Preview URL: | https://dev.pephub.pages.dev |
requirements/requirements-all.txt
Outdated
pepdbagent>=0.11.1 | ||
# pepdbagent @ git+https://github.com/pepkit/pepdbagent.git@schams2.0#egg=pepdbagent | ||
#pepdbagent>=0.11.1 | ||
pepdbagent @ git+https://github.com/pepkit/pepdbagent.git@dev#egg=pepdbagent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to change this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Python looks good. Did not review .ts files.
Address sample table issues related to copying and pasting ph_id col
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it works.. I approve. I didnt have time to go through his with a fine-toothed comb, however since there were so many changes
pephub/_version.py
Outdated
@@ -1 +1 @@ | |||
__version__ = "0.14.4" | |||
__version__ = "0.15.0_dev0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are merging to master, should we change this?
formData.append('schema_name', schemaName || ''); | ||
formData.append('description', description || ''); | ||
formData.append('private', isPrivate.toString()); | ||
formData.append('contributors', contributors || ''); | ||
formData.append('maintainers', maintainers || ''); | ||
formData.append('tags', tags ? JSON.stringify(tags) : '{}'); | ||
formData.append('version', version || ''); | ||
formData.append('release_notes', releaseNotes || ''); | ||
formData.append('lifecycle_stage', lifecycleStage || ''); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know that i started this trend, but is it ok if we append empty strings?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feels like prettier
needs run on this
Changes:
TODO: