remove once_cell (upon next MSRV bump!) #1102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the next MSRV bump might be coming up once_cell can be cut in favor of std's own Lazy primitives
WalkthroughThe changes update the Rust toolchain version requirement to 1.80 across multiple Cargo manifests and GitHub Action configuration. The dependency on the Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
tomt
8000
au
requested changes
Jun 10, 2025
There was a problem hiding this comment.
thanks! it's close to one year since the 1.80 release, so I assume it should have already made its way to major Linux distributions etc. and it should be all right to bump MSRV.
could you also update the rust-version entries in other crates (they depend on pest_meta, so I assume they all should have the MSRV bumped) + README (which mentions MSRV) + this default toolchain in CI:
pest/.github/actions/setup/action.yml
Line 11 in 7739764
|
I think this is correct? should definitely be reviewed, I don't know a lot about the CI stuff here. I just found this crate in my dependency tree |
it should be correct, there's still one small |
jimsynz
pushed a commit
to jimsynz/outrun
that referenced
this pull request
Jun 17, 2025
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [pest_derive](https://pest.rs/) ([source](https://github.com/pest-parser/pest)) | dependencies | patch | `2.8.0` -> `2.8.1` | --- ### Release Notes <details> <summary>pest-parser/pest (pest_derive)</summary> ### [`v2.8.1`](https://github.com/pest-parser/pest/releases/tag/v2.8.1) [Compare Source](pest-parser/pest@v2.8.0...v2.8.1) #### What's Changed - Add reference to ws2markdown by [@​dertuxmalwieder](https://github.com/dertuxmalwieder) in pest-parser/pest#1100 - remove once\_cell (upon next MSRV bump!) by [@​2ndDerivative](https://github.com/2ndDerivative) in pest-parser/pest#1102 The Minimum Supported Rust Version (MSRV) for default features is **1.80.0** now. #### New Contributors - [@​dertuxmalwieder](https://github.com/dertuxmalwieder) made their first contribution in pest-parser/pest#1100 - [@​2ndDerivative](https://github.com/2ndDerivative) made their first contribution in pest-parser/pest#1102 **Full Changelog**: pest-parser/pest@v2.8.0...v2.8.1 #### Warning: Semantic Versioning Note that the node tag feature in 2.6.0 was a technically semver-breaking change even though it is a backwards-compatible / non-breaking change in the meta-grammar. There may be similar non-breaking changes to the meta-grammar between minor versions in the future. These non-breaking changes, however, may translate into semver-breaking changes due to the additional variants propagated from the generated `Rule` enum. This new feature caused issues in some Cargo version resolution situations where Cargo mixed different versions of pest dependencies. For this reason, these "grammar non-breaking but semver-breaking" changes are now available only under the "grammar-extras" feature flag. If you would like to use node tags (or other future grammar features), you can do so by enabling this flag on the pest\_derive crate in your Cargo.toml: ``` ... pest_derive = { version = "2.8", features = ["grammar-extras"] } ``` </details> --- ### Configuration 📅 **Schedule**: Branch creation - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) in timezone Pacific/Auckland, Automerge - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) in timezone Pacific/Auckland. 🚦 **Automerge**: Disabled because a matching PR was automerged previously. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MC41OC4wIiwidXBkYXRlZEluVmVyIjoiNDAuNTguMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsicmVub3ZhdGUiXX0=--> Reviewed-on: https://harton.dev/outrun/outrun/pulls/60 Co-authored-by: Renovate Bot <bot@harton.nz> Co-committed-by: Renovate Bot <bot@harton.nz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the next MSRV bump might be coming up once_cell can be cut in favor of std's own Lazy primitives.
This should probably be done only then, after all this is pretty minor, but here's the change so it's on the list.
Summary by CodeRabbit
Summary by CodeRabbit