8000 Type changes by souvikmaji · Pull Request #69 · pesos/grofer · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Type changes #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Type changes #69

wants to merge 6 commits into from

Conversation

souvikmaji
Copy link
Contributor

refers to #65. this PR contains changes from #67 . So please first merge that PR to resolve #64 before considering this.

Copy link
Member
@Gituser143 Gituser143 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me @souvikmaji, considering they're just simple type changes. I'll merge the PR after another approval!

@Gituser143
Copy link
Member

Fixes #65

@Gituser143 Gituser143 linked an issue Oct 4, 2020 that may be closed by this pull request
@MadhavJivrajani MadhavJivrajani added the hacktoberfest-accepted Valid contribution and not spam label Oct 4, 2020
@MadhavJivrajani
Copy link
Member

@souvikmaji please feel free to try out any of the other issues that you'd like and we'll be more than happy to help you out with any of them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Valid contribution and not spam
Projects
None yet
3 participants
0