8000 :bug: Tooltip positioning tunning by EvaMarco · Pull Request #6418 · penpot/penpot · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

🐛 Tooltip positioning tunning #6418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025

Conversation

EvaMarco
Copy link
Contributor
@EvaMarco EvaMarco commented May 7, 2025

Related Ticket

Related task

Summary

This is a positioning tunning, some tooltip position where missplaced for 3 or 4 px.

Steps to reproduce

Screenshot from 2025-05-07 11-14-08
Make sure elements are aligned to the center

Checklist

  • Choose the correct target branch; use develop by default.
  • Provide a brief summary of the changes introduced.
  • Add a detailed explanation of how to reproduce the issue and/or verify the fix, if applicable.
  • Include screenshots or videos, if applicable.
  • Add or modify existing integration tests in case of bugs or new features, if applicable.
  • Check CI passes successfully.
  • Update the CHANGES.md file, referencing the related GitHub issue, if applicable.

@EvaMarco EvaMarco force-pushed the eva-fix-tooltip-positioning-finest branch from fe15cba to 7165eff Compare May 7, 2025 09:20
@EvaMarco EvaMarco marked this pull request as ready for review May 7, 2025 09:30
@Xaviju Xaviju self-assigned this May 7, 2025
@Xaviju
Copy link
Contributor
Xaviju commented May 7, 2025

The PR seems right but the operation numbers (6, 5 , 4) do not have any context. Is just a visual fix of an arbitrary number of pixels or they do have a meaning?

@EvaMarco EvaMarco force-pushed the eva-fix-tooltip-positioning-finest branch 2 times, most recently from c1148da to 1ac7fb8 Compare May 8, 2025 07:46
@EvaMarco
Copy link
Contributor Author
EvaMarco commented May 8, 2025

I left only harcoded numbers on the rotation transform for the arrow.

@EvaMarco EvaMarco requested a review from Xaviju May 8, 2025 08:09
@EvaMarco EvaMarco force-pushed the eva-fix-tooltip-positioning-finest branch from 1ac7fb8 to 026db69 Compare May 8, 2025 08:45
@EvaMarco EvaMarco force-pushed the eva-fix-tooltip-positioning-finest branch from 026db69 to d89d89c Compare May 8, 2025 08:59
@EvaMarco EvaMarco merged commit b71b9ed into develop May 8, 2025
9 checks passed
@EvaMarco EvaMarco deleted the eva-fix-tooltip-positioning-finest branch May 8, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0