🎉 Serialize as bytes all fill kinds #6379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8c95fc2 to
b76a04c
Compare
b76a04c to
173d6c2
Compare
2ab6269 to
fc0e81b
Compare
fc0e81b to
8609db2
Compare
elenatorro
reviewed
May 7, 2025
| (dm/get-prop image :width) | ||
| (dm/get-prop image :height)) | ||
| (sr-fills/write-image-fill! offset heap id opacity (dm/get-prop image :width) (dm/get-prop image :height)) | ||
| (h/call wasm/internal-module "_add_shape_fill") |
There was a problem hiding this comment.
Now that we're calling "_add_shape_fill" for all fill types, maybe we can just call it once at the end?
There was a problem hiding this comment.
I just tried and it turns out we need to call _add_shape_fill before (store-image) :( I did remove the redundant calls in gradients
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket
https://tree.taiga.io/project/penpot/task/10753
How to test
Open or create a file with different fill types (also fills for strokes).
Summary
This creates a unified DTO to deserialize in Wasm fill data. Now all fills have the same size count (
160bytes) and gradients have a cap of16stops.We switched to use
mem::transmuteto do deserialization (it is a raw byte copy). To be able to do that, we need to userepr(C),repr(4)andrepr(u8)to control both the alignment and layout, as well as the actual values to serialize the discriminant byte for the enum variant.Checklist
developby default.Add or modify existing integration tests in case of bugs or new features, if applicable.Update theCHANGES.mdfile, referencing the related GitHub issue, if applicable.