8000 :sparkles: Allow importing token files with reference errors by floscr · Pull Request #6374 · penpot/penpot · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

✨ Allow importing token files with reference errors #6374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 8, 2025
Merged

✨ Allow importing token files with reference errors #6374

merged 2 commits into from
May 8, 2025

Conversation

floscr
Copy link
Contributor
@floscr floscr commented Apr 28, 2025 •
edited
Loading

Related Ticket

tokens-studio#103

Summary

The UI handles missing references, so we shouldn't block users from importing data with missing references inside.

Steps to reproduce

  1. Import a file with a missing reference missing-references.json
  2. It should display in the UI

Checklist

  • Choose the correct target branch; use develop by default.
  • Provide a brief summary of the changes introduced.
  • Add a detailed explanation of how to reproduce the issue and/or verify the fix, if applicable.
  • Include screenshots or videos, if applicable.
  • Add or modify existing integration tests in case of bugs or new features, if applicable.
  • Check CI passes successfully.
  • Update the CHANGES.md file, referencing the related GitHub issue, if applicable.

@floscr floscr linked an issue Apr 28, 2025 that may be closed by this pull request
Disable missing references preventing import tokens-studio/penpot#103
Closed
@floscr floscr force-pushed the hyma/103-dont-prevent-import-missing-ref branch from 7372626 to 846de42 Compare April 28, 2025 07:59
@floscr floscr marked this pull request as ready for review April 28, 2025 08:25
@floscr floscr force-pushed the hyma/103-dont-prevent-import-missing-ref branch from 846de42 to ea5137b Compare April 29, 2025 08:43
@hirunatan hirunatan self-assigned this May 7, 2025
@floscr floscr force-pushed the hyma/103-dont-prevent-import-missing-ref branch from a6db6e8 to 06dfab3 Compare May 7, 2025 15:36
@floscr floscr requested a review from hirunatan May 7, 2025 15:47
@EvaMarco EvaMarco merged commit 92f5b5f into penpot:develop May 8, 2025
9 checks passed
@EvaMarco EvaMarco deleted the hyma/103-dont-prevent-import-missing-ref branch May 8, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hirunatan hirunatan Awaiting requested review from hirunatan

Assignees

@hirunatan hirunatan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable missing references preventing import
3 participants
@floscr @hirunatan @EvaMarco
0