8000 :recycle: Redesign form input tokens by Xaviju · Pull Request #6294 · penpot/penpot · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

♻️ Redesign form input tokens #6294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 5, 2025
Merged

♻️ Redesign form input tokens #6294

merged 2 commits into from
May 5, 2025

Conversation

Xaviju
Copy link
Contributor
@Xaviju Xaviju commented Apr 14, 2025 •
edited
Loading

Related Ticket

This story -> https://tree.taiga.io/project/penpot/us/10713?milestone=441305

Summary

Redesign form input for tokens CRUD forms as designed (see story)

This PR creates a new input* component. The input* component is a wrapper composed of label*, input-field*, and hint-message* components, functioning as a form element that adapts its UI based on configuration, making it suitable for different areas of the interface.

Checklist

  • Choose the correct target branch; use develop by default.
  • Provide a brief summary of the changes introduced.
  • Add a detailed explanation of how to reproduce the issue and/or verify the fix, if applicable.
  • Include screenshots or videos, if applicable.
  • Add or modify existing integration tests in case of bugs or new features, if applicable.
  • Check CI passes successfully.
  • Update the CHANGES.md file, referencing the related GitHub issue, if applicable.

@Xaviju Xaviju force-pushed the xaviju-10713-input-tokens branch 3 times, most recently from 392a9cb to 496af90 Compare April 28, 2025 07:54
@Xaviju Xaviju marked this pull request as ready for review April 28, 2025 08:17
@niwinz niwinz self-assigned this Apr 28, 2025
@Xaviju Xaviju requested a review from niwinz April 29, 2025 09:09
@Xaviju Xaviju force-pushed the xaviju-10713-input-tokens branch from 02cb5a6 to 99f4dd7 Compare April 29, 2025 09:35
@Xaviju Xaviju force-pushed the xaviju-10713-input-tokens branch 3 times, most recently from e96ffe7 to f4e4530 Compare April 29, 2025 13:27
@Xaviju Xaviju force-pushed the xaviju-10713-input-tokens branch 2 times, most recently from 68b98b2 to f1659c7 Compare April 29, 2025 15:14
@Xaviju Xaviju force-pushed the xaviju-10713-input-tokens branch from f1659c7 to ca3d4ad Compare April 30, 2025 07:59
@Xaviju Xaviju requested a review from niwinz April 30, 2025 10:48
@niwinz niwinz merged commit 486f036 into develop May 5, 2025
9 checks passed
@niwinz niwinz deleted the xaviju-10713-input-tokens branch May 5, 2025 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@belen-albeza belen-albeza belen-albeza left review comments

@niwinz niwinz Awaiting requested review from niwinz

Assignees

@niwinz niwinz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Xaviju @belen-albeza @niwinz
0