8000 📚 Add vercel to deployment page by BDVGitHub · Pull Request #6117 · penpot/penpot · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

📚 Add vercel to deployment page #6117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 23 commits into
base: develop
Choose a base branch
from
Open

Conversation

BDVGitHub
Copy link
Contributor

Related Ticket

Summary

Add documentation for https://vercel.com to deploy plugin

Steps to reproduce

Checklist

  • Choose the correct target branch; use develop by default.
  • Provide a brief summary of the changes introduced.
  • Add a detailed explanation of how to reproduce the issue and/or verify the fix, if applicable.
  • Include screenshots or videos, if applicable.
  • Add or modify existing integration tests in case of bugs or new features, if applicable.
  • Check CI passes successfully.
  • Update the CHANGES.md file, referencing the related GitHub issue, if applicable.

Add Vercel to the examples
WIP (you need to have an own domain, need to discuss with Penpot whether a domain can be provided for plugins or a separate extension at https://penpot.app/.... since you cant use Vercel domain to deploy
@BDVGitHub BDVGitHub changed the title 📚 WIP Add Vercel to 3.Deployment 📚 WIP Update 3.Deployment Mar 19, 2025
@BDVGitHub BDVGitHub marked this pull request as ready for review April 1, 2025 18:53
@BDVGitHub BDVGitHub changed the title 📚 WIP Update 3.Deployment 📚 Update 3.Deployment Apr 2, 2025
Add website link to Title of chapter
Forgot to add wesite link for Surge
Add Vercel logo
Add Netlify and Cloudflare logo
Update logos changed hight to 32px
Insert logos Vercel, Netlify and Cloudflare
@BDVGitHub BDVGitHub changed the title 📚 Update 3.Deployment 📚 Chore: update 3.Deployment Apr 21, 2025
@mavalroot mavalroot self-assigned this Apr 23, 2025
Copy link
Contributor
@mavalroot mavalroot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey.

Thank you very much for your contribution. We really appreciate your time and effort. Before we can proceed with your PR, there are a few important points we'd like to address:

  • Please take a moment to review our contributing page, as your PR doesn't currently follow the guidelines.
  • The guide appears to be incomplete—it doesn't cover potential CORS issues or the full deployment process. We'd recommend reviewing our existing guides and aligning your content accordingly.
  • Please avoid including unnecessary images and ensure that the current format is respected. Specifically, the use of logos should be removed.
  • We also ask that you pay closer attention to typos, capitalization, and overall formatting to maintain the quality and consistency of our documentation.
  • Lastly, the section numbering requires correction—there are currently two sections labeled 3.3 and no 3.2. Your content should be placed after the "Surge" section, making it the new section 3.5.

Once these adjustments are made, we would be happy to review your contribution again. Thank you once again for your initiative and collaboration.

@BDVGitHub BDVGitHub changed the title 📚 Chore: update 3.Deployment 📚 Add vercel to deployment page Apr 23, 2025
@BDVGitHub
Copy link
Contributor Author
BDVGitHub commented Apr 23, 2025

Hey

Done
Have read the contributing.md file but feel it is too limited
For example info obtained from Andy on guidelines is nowhere to be found in the document.
https://community.penpot.app/t/add-vercel-to-plugin-deployment/7920/5

  • Please take a moment to review our contributing page, as your PR doesn't currently follow the guidelines.

Done

  • Please avoid including unnecessary images and ensure that the current format is respected. Specifically, the use of logos should be removed.

Did my best, myself, I cannot see how the layout will look definitively. This makes it impossible to check certain things.

  • We also ask that you pay closer attention to typos, capitalization, and overall formatting to maintain the quality and consistency of our documentation.

Done, Vercel does not belong at the very bottom of the list so have moved it up a bit.

  • Lastly, the section numbering requires correction—there are currently two sections labeled 3.3 and no 3.2. Your content should be placed after the "Surge" section, making it the new section 3.5.

@BDVGitHub BDVGitHub requested a review from mavalroot May 4, 2025 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0