8000 Use TypeError instead of ValueError where appropriate. by pelme · Pull Request #59 · pelme/htpy · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use TypeError instead of ValueError where appropriate. #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 14, 2024
Merged

Use TypeError instead of ValueError where appropriate. #59

merged 1 commit into from
Sep 14, 2024

Conversation

pelme
Copy link
Owner
@pelme pelme commented Sep 14, 2024

In #58 , @mixmastamyk noted that we raise ValueError where we should instead use TypeError:

... Unexpected data types result in a ValueError (which probably should be a TypeError, now that I think of it) ...

This PR changes all usages of ValueError into TypeError.

@pelme pelme merged commit 408f70f into main Sep 14, 2024
13 checks passed
@pelme pelme deleted the typeerror branch September 14, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pelme
0