Add grammarSource option and new source key to the location information
#95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I really like this conceptually, but haven't started to review the patch yet. Quick question first: are you ok with delaying this until after 1.1? I think it's going to need a little bit of bake time, and I want to get 1.1 out so that the docs on the site match the code we're shipping. |
|
Yes, sure. |
hildjj
reviewed
Apr 22, 2021
…nformation This is the first step to the import feature
source option and new source key to the location informationgrammarSource option and new source key to the location information
hildjj
requested changes
Apr 23, 2021
|
Done. Please squash when merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step to the
importfeature.New option allows to specify source location information and in the future will help to distinguish errors from different files when import other grammars will be supported.
I'll plan to move from WIP status after #89 will be merged. Now you can comment on overall design.