Remove unused rules #594
Merged
Remove unused rules #594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a0d3032 to
29d24d4
Compare
1b0cd5c to
8a1b389
Compare
|
Removed the name->rule caching, since it didn't seem to affect performance at all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove superfluous rules, merged character classes, and proxy rules all at the same time, by following the call graph from allowedStartRules after other modifications have been done. Hopefully this isn't O(n^2); I'm pretty sure it's just O(n) due to checking to see if we have already checked a given rule. Infinite loops shouldn't be possible due to them having been caught by report-infinite-recursion and report-infinite-repetition.
This patch builds on #593, and will be rebased on top of it before landing. It removes the previous attempt at adding proxies in that patch.