8000 docs(drawer): Updates design guidelines for v6. by edonehoo · Pull Request #4626 · patternfly/patternfly-org · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

docs(drawer): Updates design guidelines for v6. #4626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 16, 2025

Conversation

edonehoo
Copy link
Collaborator

Closes #4546

@edonehoo
Copy link
Collaborator Author

IDK if this is a big deal, but I noticed that the "overlay drawer" image still pushes the page content to the side, which isn't 100% accurate. It should just overlay it, so the page content should extend to the full width of the screen, including the drawer. I couldn't figure out how to fix it in Figma, so I can coordinate with whoever else can!

@patternfly-build
Copy link
Contributor
patternfly-build commented May 20, 2025

@bekah-stephens
Copy link
Contributor

IDK if this is a big deal, but I noticed that the "overlay drawer" image still pushes the page content to the side, which isn't 100% accurate. It should just overlay it, so the page content should extend to the full width of the screen, including the drawer. I couldn't figure out how to fix it in Figma, so I can coordinate with whoever else can!

I'm not sure the best way to fix the component itself, but did a quick fix and updated the screenshot. I would say pull in the fixed screenshot for the guidelines and then add the component problem to the audit doc.

@edonehoo
Copy link
Collaborator Author

@bekah-stephens ty! Updated and added to the audit sheet

@edonehoo edonehoo changed the title Iss4546 docs(drawer): Updates design guidelines for v6. May 27, 2025
@andrew-ronaldson andrew-ronaldson merged commit 7c09b7c into patternfly:main Jun 16, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs - Update Drawer guidelines
4 participants
0