Tags: patchew-project/libvirt
Tags
qemu: Switch to virtio-scsi on ARM Similar to x86, the default SCSI controller model for ARM is lsilogic. But unlike x86, the ARM virt machine type prefers virtio devices. Switch the default controller model for ARM from lsilogic to virtio-scsi. Signed-off-by: Jim Fehlig <jfehlig@suse.com> Message-Id: <20250626215356.23591-1-jfehlig@suse.com>
tests: validate an XML config with USB vendor/product set The USB vendor/product is usually translated into a device/bus at startup using the hostdev logic. We don't run the latter in the unit test suite, but we can fake it by hardcoding a translation. This demonstrates that we format the command line with the normal device/bus properties, even when vendor/product is set. Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> Message-Id: <20250626084724.2049525-1-berrange@redhat.com>
qemu: Add support for RBD namespace. Since Nautilus ceph supports separate image namespaces within a pool for tenant isolation and QEMU adds it as a rbd blockdev options from 5.0.0. The source name with format "<pool>/<namespace>/<image>" could be used to access a rbd image with namespace. Add unit tests for this attribute. https://bugzilla.redhat.com/show_bug.cgi?id=1816909 Closes: https://gitlab.com/libvirt/libvirt/-/issues/405 Signed-off-by: Han Han <hhan@redhat.com> Signed-off-by: Peter Krempa <pkrempa@redhat.com> Message-Id: <b2ae1e49d0e04260c8c30d94a82aa94652f3213e.1750866876.git.pkrempa@redhat.com>
docs: domain: Add documentation for Intel TDX guest Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com> Message-Id: <20250625094533.234897-22-zhenzhong.duan@intel.com>
[PATCH v2] remote/stream-event: Fix a memory leak in remoteStreamCal…
…lbackFree()
The ff callback is never called in remoteStreamCallbackFree() because
cbdata->cb can not be NULL. This causes a leak of 'cbdata->opaque'.
The leak can be reproduced by attaching and detaching to the console of
an VM using `virsh console`.
ASAN reports the leak stack as:
Direct leak of 288 byte(s) in 1 object(s) allocated from:
#0 0x7f6edf6ba0c7 in calloc (/lib64/libasan.so.8+0xba0c7)
libvirt#1 0x7f6edf5175b0 in g_malloc0 (/lib64/libglib-2.0.so.0+0x615b0)
libvirt#2 0x7f6ede6d0be3 in g_type_create_instance (/lib64/libgobject-2.0.so.0+0x3cbe3)
libvirt#3 0x7f6ede6b82cf in g_object_new_internal (/lib64/libgobject-2.0.so.0+0x242cf)
libvirt#4 0x7f6ede6b9877 in g_object_new_with_properties (/lib64/libgobject-2.0.so.0+0x25877)
libvirt#5 0x7f6ede6ba620 in g_object_new (/lib64/libgobject-2.0.so.0+0x26620)
libvirt#6 0x7f6edeb78138 in virObjectNew ../src/util/virobject.c:252
libvirt#7 0x7f6edeb7a78b in virObjectLockableNew ../src/util/virobject.c:274
libvirt#8 0x558251e427e1 in virConsoleNew ../tools/virsh-console.c:369
libvirt#9 0x558251e427e1 in virshRunConsole ../tools/virsh-console.c:427
Signed-off-by: Liu Song <liu.song13@zte.com.cn>
Message-Id: <20250625092733465LDt9KLFZDVzUzdTKcXSwz@zte.com.cn>
conf: Add extraArgs option to passt backend Add support for passing extra arguments to the passt binary through the domain XML configuration. This allows users to specify additional command-line arguments for passt that are not covered by existing structured fields. The new extraArgs attribute is added to the backend element: <backend type='passt' extraArgs='--debug --no-dhcp -v'/> The extraArgs string is parsed using g_shell_parse_argv() to split it into individual arguments before passing them to the passt command. This change includes: - New field in virDomainNetBackend structure - XML schema update to allow extraArgs attribute - Parsing and formatting support in domain_conf.c - Backend comparison function update - Memory cleanup for the new field - QEMU passt integration to use the extra arguments - Comprehensive tests for both user and vhostuser interfaces This is an RFE to gather feedback on the approach. I have a few questions for the community: 1. Is this general approach of adding extraArgs reasonable, or should we instead focus on adding specific structured fields for each passt option? 2. Should extraArgs be marked as unsupported/unstable in the documentation, with a clear indication that it's primarily intended for development and testing purposes? 3. Are there any security concerns with allowing arbitrary arguments to be passed to the passt binary via XML configuration? 4. Would it be better to validate the arguments against a known allowlist rather than allowing any argument string? The current implementation uses g_shell_parse_argv() to safely parse the argument string, but I'm open to feedback on whether additional validation or restrictions should be applied. Signed-off-by: Enrique Llorente <ellorent@redhat.com> Message-Id: <20250625074016.294856-1-ellorent@redhat.com>
qemu_monitor_json: Use proper initializer in qemuMonitorJSONGetBlockI…
…nfo()
Inside of qemuMonitorJSONGetBlockInfo() there's a for loop in
which a variable of struct qemuDomainDiskInfo type is declared
and initialized as { false }. This works only because stdbool.h
declares 'false' as a macro, so preprocessor expands initializer
to proper form of { 0 }.
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Message-Id: <9551e54a907e4ba9d8bc761e05f1d3fb1eb23a68.1750768078.git.mprivozn@redhat.com>
docs: clarify how to build without -Werror --werror does not accept any arguments for me and setting git_werror was also needed to disable it with git. Signed-off-by: Ján Tomko <jtomko@redhat.com> Message-Id: <42c99a068a589a8fdd38febbdf6d8e7371e3e45d.1750780132.git.jtomko@redhat.com>
qemu: Replace usb-storage with usb-bot usb-storage is a compound device that automatically creates a USB mass storage device and a SCSI device as its backend. Unfortunately it lacks some configuration options that are usually present with a SCSI device, and cannot represent CD-ROM in particular. Replace usb-storage with usb-bot, which can be combined with a manually created SCSI device. libvirt will configure the SCSI device in a way identical with how QEMU does for usb-storage except that now it respects a configuration option to represent CD-ROM. Resolves: https://gitlab.com/libvirt/libvirt/-/issues/368 Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com> Signed-off-by: Peter Krempa <pkrempa@redhat.com> Message-Id: <3ff4b9fad0eab397866824d204d05371c16cdbc0.1750705681.git.pkrempa@redhat.com>
qemu: format pt and xstup on the command line Signed-off-by: Ján Tomko <jtomko@redhat.com> Reviewed-by: Peter Krempa <pkrempa@redhat.com> Message-Id: <33430dbdec9a46481ee023836582d8a9f9063f11.1750243583.git.jtomko@redhat.com>
PreviousNext