Update scale-info to v2 #626
Conversation
|
jFYI, this is a breaking change that will cascade like #623 |
|
@wigy-opensource-developer As @ordian points out, we'll need a major bump of |
|
writing comments on Github at the same time is fun :) |
| @@ -15,7 +15,8 @@ impl-serde = { version = "0.3.1", path = "impls/serde", default-features = false | |||
| impl-codec = { version = "0.6.0", path = "impls/codec", default-features = false, optional = true } | |||
| impl-num-traits = { version = "0.1.0", path = "impls/num-traits", default-features = false, optional = true } | |||
| impl-rlp = { version = "0.3", path = "impls/rlp", default-features = false, optional = true } | |||
| scale-info-crate = { package = "scale-info", version = ">=0.9, <2", features = ["derive"], default-features = false, optional = true } | |||
| # See https://github.com/paritytech/parity-common/pull/556#issuecomment-872127496 why this is here: | |||
There was a problem hiding this comment.
this link doesn't explain why this is here, which is I think self-explanatory (it's a feature)
|
Sorry, it seems like we all have different scopes and some crates in the big-big DAG of cumulus dependencies created another version ripple here. Maybe we need a better way to navigate that big-big DAG. |
| @@ -15,7 +15,8 @@ impl-serde = { version = "0.3.1", path = "impls/serde", default-features = false | |||
| impl-codec = { version = "0.6.0", path = "impls/codec", default-features = false, optional = true } | |||
| impl-num-traits = { version = "0.1.0", path = "impls/num-traits", default-features = false, optional = true } | |||
| impl-rlp = { version = "0.3", path = "impls/rlp", default-features = false, optional = true } | |||
| scale-info-crate = { package = "scale-info", version = ">=0.9, <2", features = ["derive"], default-features = false, optional = true } | |||
| # See https://github.com/paritytech/parity-common/pull/556#issuecomment-872127496 why this is here: | |||
| scale-info-crate = { package = "scale-info", version = "2", features = ["derive"], default-features = false, optional = true } | |||
There was a problem hiding this comment.
Ok, let's pull this YOLO trick once again
| scale-info-crate = { package = "scale-info", version = "2", features = ["derive"], default-features = false, optional = true } | |
| scale-info-crate = { package = "scale-info", version = ">=0.9, <3", features = ["derive"], default-features = false, optional = true } |
There was a problem hiding this comment.
<3 you meant? Also, isn't it better to exclude 0.9 and 1.0.0 now?
There was a problem hiding this comment.
With this we'd only need a minor release of primitive-types yes?
There was a problem hiding this comment.
Yes, I meant <3 and yes, this would be a patch release. And we don't need to release anything else. Only update substrate/polkadot/cumulus
There was a problem hiding this comment.
Okay, I get it. Although MSRV and edition 2021 is already in the Cargo.toml which technically makes it a major release, right?
There was a problem hiding this comment.
We already published that changes in #623.
There was a problem hiding this comment.
Could you bump the version in this PR and update the change as well please?
There was a problem hiding this comment.
Ah, wait, scale-info also used in ethereum-types. I'm afraid, there's no getting away with breaking release then (sorry).
We can do the same trick with ethereum-types and ethbloom.
|
closing in favor of #627 |
|
Wow. Thanks a lot. I had to be AFK for 3 hours and you took the bullet for me. |
We should get to a release of primitive-types that could be included in a Substrate version that depends on Scale v3. Yeah 😄