8000 XCM revamp by gavofyork · Pull Request #2836 · paritytech/polkadot · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

XCM revamp #2836

Merged
merged 43 commits into from
Apr 7, 2021
Merged

XCM revamp #2836

merged 43 commits into from
Apr 7, 2021

Conversation

gavofyork
Copy link
Member
@gavofyork gavofyork commented Apr 7, 2021 •
edited
Loading
  • Make the Xcm and Order enums generic over the Call type.
  • Introduce Order::BuyExecution
  • Introduce additional traits WeightTrader, ShouldExecute and WeightBounds.
  • Introduce basic implementions of each trait, including several sensible ones for ShouldExecute.
  • Introduce a mock test environment and plenty of tests.

TODO:

  • Rename Xcm -> opaque::Xcm and rename XcmGeneric -> generic::Xcm, same for Order and VersionedXcm
  • Move builder structs in xcm-executor over into xcm-builder
  • Implement MatchesFungible for tuples (#MATCHTUPLE)

gavofyork and others added 24 commits April 1, 2021 22:13
@gavofyork
Remove unused relaying XCM
7bac2e4
@gavofyork
Aggregate HRMP (XCMP/HMP) messages. Payloads for spambot.
f2929f6
@gavofyork
Revert lock
3aae107
@gavofyork
Fix
016c785
@gavofyork
Broken example
0be98c3
@gavofyork
Introduce fee payment mechanics into XCM.
b908c5b
@gavofyork
Weight limitations on XCM execution
03fa34c
@gavofyork
Mock environment for tests and the first test
92ec3c4
@gavofyork
Tests for XCM and a few refactors.
8b5b67e
@gavofyork
Remove code that's not ready
cd713bf
@gavofyork
Fix for an XCM and an additional test
b1ff9f6
@gavofyork
Query response system
9947a81
@gavofyork
XCMP message dispatch system reimagining
31b851e 
- Moved most of the logic into xcm-handler pallet
- Altered the outgoing XCMP API from push to pull
- Changed underlying outgoing queue data structures to avoid multi-page read/writes
- Introduced queuing for incoming messages
- Introduced signal messages as a flow-control sub-stream
- Introduced flow-control with basic threshold back-pressure
- Introduced overall weight limitation on messages executed
- Additonal alterations to XCM APIs for the new system
@gavofyork
Some build fixes
24e5dcc
@gavofyork
Merge remote-tracking branch 'origin/master' into gav-rococo-stuff
6a91561
@gavofyork
Remove the Encode bounds sprayed around
2c53ffe
@gavofyork
More faff
84826e8
@gavofyork
Fix bounds amek use latest scale codec.
d0a5148
@shawntabrizi
remove println
f1515bf
@shawntabrizi
fixes
df6a667
@shawntabrizi
Fix XcmExecutor Tests
9051563
@gavofyork
Fix XCM bounds using derivative crate
54fd800
@gavofyork
Merge branch 'gav-new-xcm' of github.com:paritytech/polkadot into gav…
9e1500b 
…-new-xcm
@gavofyork
Refactor names of XcmGeneric &c into Xcm
a959601
@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Apr 7, 2021
@gavofyork gavofyork added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Apr 7, 2021
@gavofyork gavofyork mentioned this pull request Apr 7, 2021
Merged
shawntabrizi
shawntabrizi reviewed Apr 7, 2021
View reviewed changes
shawntabrizi
shawntabrizi reviewed Apr 7, 2021
View reviewed changes
shawntabrizi
shawntabrizi reviewed Apr 7, 2021
View reviewed changes
gavofyork and others added 2 commits April 7, 2021 14:39
@gavofyork @shawntabrizi
Update runtime/parachains/src/ump.rs
9f4f279 
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
@gavofyork
Docs
29767d4
shawntabrizi
shawntabrizi reviewed Apr 7, 2021
View reviewed changes
xcm/xcm-builder/src/location_conversion.rs
let mut result = location.clone();
for (i, j) in location.iter_rev()
.map(|j| match j {
Junction::Parent => ancestry.take_first().unwrap_or(Junction::OnlyChild),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note to revisit this

shawntabrizi
shawntabrizi reviewed Apr 7, 2021
View reviewed changes
shawntabrizi
shawntabrizi reviewed Apr 7, 2021
View reviewed changes
@gavofyork gavofyork mentioned this pull request Apr 7, 2021
Closed
47 tasks
@gavofyork gavofyork merged commit 12a3e03 into master Apr 7, 2021
@gavofyork gavofyork deleted the gav-new-xcm branch April 7, 2021 20:38
shawntabrizi added a commit that referenced this pull request Apr 8, 2021
@shawntabrizi
Revert "XCM revamp (#2836)"
c6c22d4 
This reverts commit 12a3e03.
rphmeier added a commit that referenced this pull request Apr 8, 2021
@rphmeier
Revert "XCM revamp (#2836)"
d94cbb3 
This reverts commit 12a3e03.
rphmeier added a commit that referenced this pull request Apr 9, 2021
@rphmeier
Revert "Revert "XCM revamp (#2836)""
980409e 
This reverts commit d94cbb3.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shawntabrizi shawntabrizi shawntabrizi approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gavofyork @shawntabrizi
0