Fix using __args argument on a patch targetting a method with an out bool parameter to fail on the Unity Mono platform #657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…[] __args argument and the patched class had a out bool parameter https://discord.com/channels/131466550938042369/361891646742462467/1357727821212024913
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion started here: https://discord.com/channels/131466550938042369/361891646742462467/1357738423535796244
A small reproduceable sample code is seen here (as a UnityModManager mod)
I added a fix and a test.
Note: I could only reproduce on the Unity Mono runtime. Testing on .NET or .NET Framework (at least the versions I tried) didn't produce the error under the same conditions.
See test case in #658