8000 Fix re-running admindb migration failures by akshay196 · Pull Request #205 · paralus/paralus · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix re-running admindb migration failures #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

akshay196
Copy link
Member

What does this PR change?

Make all admindb migration queries re-entrance so re-running migration would not fail.

Does the PR depend on any other PRs or Issues? If yes, please list them.

None

Checklist

I confirm, that I have...

  • Read and followed the contributing guide in CONTRIBUTING.md
  • Added tests for this PR
  • Formatted the code using go fmt (if applicable)
  • Updated documentation on the Paralus docs site (if applicable)
  • Updated CHANGELOG.md

@codecov-commenter
Copy link

Codecov Report

Merging #205 (567685a) into main (da418fd) will increase coverage by 0.20%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #205      +/-   ##
==========================================
+ Coverage   34.41%   34.62%   +0.20%     
==========================================
  Files         
8000
 74       74              
  Lines       11692    11692              
==========================================
+ Hits         4024     4048      +24     
+ Misses       7123     7094      -29     
- Partials      545      550       +5     

see 1 file with indirect coverage changes

Make all admindb migration queries re-entrance so re-running migration
would not fail.

Signed-off-by: Akshay Gaikwad <akgaikwad001@gmail.com>
@akshay196 akshay196 force-pushed the fix-migration-failures branch from 567685a to f0ae8a0 Compare April 27, 2023 14:59
@niravparikh05 niravparikh05 merged commit d88c82e into paralus:main Apr 28, 2023
@akshay196 akshay196 deleted the fix-migration-failures branch April 28, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0