AST validate that a contract does not have a function with contract name #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onbjerg
requested changes
Nov 14, 2024
DaniPopes
reviewed
Nov 15, 2024
Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com>
Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com>
ferranbt
commented
Nov 18, 2024
| for item in body.iter() { | ||
| if let ast::ItemKind::Function(ast::ItemFunction { kind, header, body: _ }) = &item.kind | ||
| { | ||
| if *kind == ast::FunctionKind::Function { |
There was a problem hiding this comment.
Unsure if there is a more idiomatic way to chain this if statements.
There was a problem hiding this comment.
There will be when let-chains are stabilized :)
DaniPopes
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an AST validation check similar to this which verifies that a function does not have the same name as the contract.
Note, eventually this can be merged into a specific AST contract level checker.