8000 Fix subdomain inheritance for nested blueprints by pgjones · Pull Request #4935 · pallets/flask · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix subdomain inheritance for nested blueprints #4935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 4, 2023
Merged

Fix subdomain inheritance for nested blueprints #4935

merged 2 commits into from
Jan 4, 2023

Conversation

pgjones
Copy link
Member
@pgjones pgjones commented Jan 4, 2023

This replaces #4856

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@davidism
Copy link
Member
davidism commented Jan 4, 2023

It's weird that a user could supply both a path and a subdomain, and end up with a joined path that's only accessible at the joined subdomain. But at least it's consistent. You either get the parent subdomain, or a subdomain below the parent, which is the same as the path. They're just not intended to be used at the same time.

davidism
davidism approved these changes Jan 4, 2023
View reviewed changes
@pgjones
Ensure that blueprint subdomains suffix-chain
cabda59 
This ensures that a child's subdomain prefixs any parent subdomain
such that the full domain is child.parent.domain.tld and onwards with
further nesting. This makes the most sense to users and mimics how
url_prefixes work (although subdomains suffix).
@davidism davidism mentioned this pull request Jan 4, 2023
Closed
6 tasks
@davidism davidism merged commit 836866d into pallets:main Jan 4, 2023
@davidism davidism added this to the 2.3.0 milestone Jan 4, 2023
@davidism davidism linked an issue Jan 4, 2023 that may be closed by this pull request
Nested blueprints are not respected when mounted on subdomains #4834
Closed
@pgjones pgjones mentioned this pull request Jan 7, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davidism davidism davidism approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.

Nested blueprints are not respected when mounted on subdomains
3 participants
@pgjones @davidism @confuzeus
0