8000 fix: can't run tests in projectdo without `npm` installed by alanpearce · Pull Request #25 · paldepind/projectdo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: can't run tests in projectdo without npm installed #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2025
Merged

fix: can't run tests in projectdo without npm installed #25

merged 1 commit into from
Apr 10, 2025

Conversation

alanpearce
Copy link
Contributor

fixes #24

paldepind
paldepind reviewed Apr 9, 2025
View reviewed changes
Copy link
Owner
@paldepind paldepind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a conflict at the moment, but otherwise it looks fine.

I guess it's not entirely clear what should be run in a situation where two valid options exist. But let's do it like this to at least fix the problem in Projectdo.

@paldepind
Copy link
Owner

Thanks for fixing this! :)

@paldepind paldepind merged commit ec6d243 into paldepind:main Apr 10, 2025
1 check passed
@alanpearce alanpearce deleted the fix-24 branch April 10, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paldepind paldepind paldepind left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test doesn't work in this repo without npm installed
2 participants
@alanpearce @paldepind
0