Feature: Choose shell in Shell Plugin - Testers wanted #638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue #620 requests the shell plugin to support
bash. This PR adds an option to set the bash.Due to the nature of plugin configurations it is not possible to restrain the choosable shells to the available shells.
However, the plugin errors, if powershell is set on non-windows systems or sh/bash is set on windows systems.
It defaults to powershell on windows and sh on linux.
The plugin is not yet tested!
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Checklist: