8000 Update SQLite3 Message Search query logic by bullseye555 · Pull Request #624 · pagermon/pagermon · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update SQLite3 Message Search query logic #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Update SQLite3 Message Search query logic #624

wants to merge 4 commits into from

Conversation

bullseye555
Copy link

Description

Update from MATCH (whole word results only) to LIKE (string results, regardless of where the string is in the decode) for SQLite3 Message Search string

Fixes #623

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Tested searching whole-words
  • Tested searching for partial words
  • Tested searching for numbers
  • Tested searching for strings containing symbols (eg: @,#/*!$^&()-+.)

##NOTE: SQL wildcard symbols _ and % continue to function as wildcard symbols

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated changelog.md with changes made

@bullseye555
Update SQLite3 Search logic
c78a355 
Update from MATCH (whole word results only) to LIKE (string results, regardless of where the string is in the decode)
@bullseye555
Update SQLite3 Search logic
60fe3ed 
Update commentary wording
@bullseye555
Update CHANGELOG.md
5856f88
@bullseye555
Merge pull request #1 from bullseye555/bullseye555-pm_issue-623
c1ae606 
Bullseye555 pm issue 623
@DanrwAU DanrwAU changed the base branch from master to develop April 20, 2025 02:53
@DanrwAU
Copy link
Member
DanrwAU commented Apr 20, 2025

Rebased to develop

@DanrwAU
Copy link
Member
DanrwAU commented Apr 20, 2025

This bug exists on other database types also afaik. Any chance of a holistic fix across all DB types?

@eopo
Copy link
Collaborator
eopo commented Apr 20, 2025

We could switch from MATCH to LIKE in general. All three DBs systems currently supported would support LIKE, with the only (manageable) pinpoint being them not uniform with case sensitivity. We might want to have some way to make whole world search available though. I think it might be best to implement some sort of query language that enables searches as
alias:"CITY" message:"FIRE" -message:"Test"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve Search in SQLite3 DBs
3 participants
@bullseye555 @DanrwAU @eopo
0