10000 PDR scraper, R-Pi installer by Shaggs · Pull Request #581 · pagermon/pagermon · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

PDR scraper, R-Pi installer #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

PDR scraper, R-Pi installer #581

wants to merge 4 commits into from

Conversation

Shaggs
Copy link
Contributor
@Shaggs Shaggs commented Nov 14, 2023

Description

Add a scraper via serial for decoders. This will allow users with pager decoders to upload messages. Mulit-part messages are handled via the device so no need to mess around with that side of things.

The python does have some library's that need to be installed.

Raspberian now has its own version of Nodejs installed being version 6. the install script will remove that version and install version 18 - 20

Fixes # (issue)
Raspbain nodejs version 6 #579

Type of change

Please delete options that are not relevant.

  • [ V] Bug fix (non-breaking change which fixes an issue)
  • [ V] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

New install of Raspbain to try install script.
PDR.py has been used on another project of mine for 3 years now with no issues.

Checklist:

  • [ V] My code follows the style guidelines of this project
  • [ V] I have performed a self-review of my own code
  • [ V] I have commented my code, particularly in hard-to-understand areas
  • I have updated changelog.md with changes made

@marshyonline marshyonline requested a review from a team November 28, 2023 04:50
s3m1s0n1c
s3m1s0n1c reviewed Nov 29, 2023
View reviewed changes
Copy link
Member
@s3m1s0n1c s3m1s0n1c left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR @Shaggs

See my suggestions I made in comments..

Will test it the next few days and give more feedback.

Don't think there will be many people who will have access to these devices..

I was lucky and managed to get a PSR3000 dirt cheap...

Thanks
Sonic

Shaggs
Shaggs commented Nov 29, 2023
View reviewed changes
Copy link
Contributor Author
@Shaggs Shaggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will make some more changes when time permits. Those that use python shouldn't have too many issues.

Happy to answer any that come in until I can push updates

@s3m1s0n1c
Copy link
Member

@Shaggs

I get the following error..

Guess the output of mine is different so unable to review it..

Traceback (most recent call last):
File "pdr.py", line 46, in
line = line.decode('utf-8')
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xff in position 2: invalid start byte

@geelongmicrosoldering
Copy link
Collaborator

Guess the output of mine is different so unable to review it..

Having worked with a few different hardware decoders, i can tell you that the output of all of them differ slightly. Its also usually programmable.

Some of them also output messages to a socket rather than UART. So you have to setup a socket listener on the server and then pipe the data somewhere.

For that reason i basically make the solution on the fly. Theres a few ways to approach that, but the easiest way for most would be to form a string that looks like the output of multimon and pipe it straight to reader.js

You'll have a hard time coming up with a one size fits all solution, even with hardware decoders from the same manufacturers, in my experience.

@eopo
Copy link
Collaborator
eopo commented Jan 7, 2024

I suggest not merging that into the main repo, but rather have it as a separate repo and link to it in the readme.

@eopo
Copy link
Collaborator
eopo commented Jan 7, 2024

Also, please always keep different features in their own respective branches and pull requests, so we can merge one and reject the other. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s3m1s0n1c s3m1s0n1c s3m1s0n1c left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Shaggs @s3m1s0n1c @geelongmicrosoldering @eopo
0