8000 [#IOCIT-56] Redis types update by arcogabbo · Pull Request #115 · pagopa/io-spid-commons · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[#IOCIT-56] Redis types update #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2022
Merged

[#IOCIT-56] Redis types update #115

merged 1 commit into from
Jul 14, 2022

Conversation

arcogabbo
Copy link
Contributor

This PR depends on #114

List of Changes

Updated passport to 0.6.0 to fix a vulnerability (done automatically in the PR mentioned above)
Updated @types/redis library from 2.8.14 to 2.8.32

Motivation and Context

Fix vulnerability and make the library more stable by using the same redis types library of io-backend

How Has This Been Tested?

Build and unit tests passed.
I also tested this library on hub-spid-login and io-backend(the latest through io-mock)

Screenshots (if appropriate):

Types of changes

  • [] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@pagopa-github-bot
Copy link
Contributor
pagopa-github-bot commented Jul 13, 2022 •
edited
Loading
Warnings
⚠️ Please include a Pivotal story at the beginning of the PR title (see below).

Example of PR titles that include pivotal stories:

  • single story: [#123456] my PR title
  • multiple stories: [#123456,#123457,#123458] my PR title

Generated by 🚫 dangerJS against e6a95c2

@arcogabbo arcogabbo mentioned this pull request Jul 13, 2022
Merged
@dpulls
Copy link
dpulls bot commented Jul 14, 2022

🎉 All dependencies have been resolved !

@BurnedMarshal BurnedMarshal changed the title [#IOCIT-56] passport update [#IOCIT-56] Redis types update Jul 14, 2022
@arcogabbo arcogabbo force-pushed the IOCIT-56-passport-update branch from 0579bbd to e6a95c2 Compare July 14, 2022 13:35
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@BurnedMarshal BurnedMarshal merged commit 4911f70 into master Jul 14, 2022
@BurnedMarshal BurnedMarshal deleted the IOCIT-56-passport-update branch July 14, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BurnedMarshal BurnedMarshal BurnedMarshal approved these changes

@francescopersico francescopersico Awaiting requested review from francescopersico francescopersico is a code owner

@AleDore AleDore Awaiting requested review from AleDore AleDore is a code owner

@balanza balanza Awaiting requested review from balanza

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arcogabbo @pagopa-github-bot @BurnedMarshal
0