8000 Add missing files in npm bundle by BurnedMarshal · Pull Request #69 · pagopa/io-spid-commons · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add missing files in npm bundle #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 25, 2021
Merged

Add missing files in npm bundle #69

merged 1 commit into from
Jan 25, 2021

Conversation

BurnedMarshal
Copy link
Contributor

Into the npm package, all dist subfolder was missing.

@pagopa-github-bot
Copy link
Contributor
Warnings
⚠️ Please include a Pivotal story at the beginning of the PR title (see below).

Example of PR titles that include pivotal stories:

  • single story: [#123456] my PR title
  • multiple stories: [#123456,#123457,#123458] my PR title

Generated by 🚫 dangerJS against e49c6bf

@codecov
Copy link
codecov bot commented Jan 25, 2021

Codecov Report

Merging #69 (e49c6bf) into master (56e2e28) will increase coverage by 0.79%.
The diff coverage is 86.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
+ Coverage   66.26%   67.06%   +0.79%     
==========================================
  Files          11       11              
  Lines         750      759       +9     
  Branches      117      123       +6     
==========================================
+ Hits          497      509      +12     
+ Misses        252      249       -3     
  Partials        1        1
Impacted Files Coverage Δ
src/config.ts 100.00% <ø> (ø)
src/strategy/spid.ts 37.20% <0.00%> (+0.25%) ⬆️
src/index.ts 64.19% <92.85%> (+4.77%) ⬆️
src/utils/response.ts 45.45% <0.00%> (+9.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a13d5a...e49c6bf. Read the comment docs.

@BurnedMarshal BurnedMarshal mentioned this pull request Jan 25, 2021
Closed
@balanza
Copy link
Contributor
balanza commented Jan 25, 2021

great catch, thanks!

@balanza balanza merged commit 3cf6c41 into master Jan 25, 2021
@balanza balanza deleted the fix-npm-build-files branch January 25, 2021 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balanza balanza balanza approved these changes

@AleDore AleDore Awaiting requested review from AleDore AleDore is a code owner

@francescopersico francescopersico Awaiting requested review from francescopersico francescopersico is a code owner

@gunzip gunzip Awaiting requested review from gunzip gunzip is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BurnedMarshal @pagopa-github-bot @balanza
0