Hyperspy 2.0.0 Changes #969
Conversation
6262c56 to
6faa659
Compare
|
Failures are due to zenodo... |
8d7c97c to
65c0291
Compare
|
@ericpre or @hakonanes or @magnunor any chance one of you can look at this? The ellipse tools need to be cleaned up but I would rather do that in a different PR. In any case I think things are much cleaner than they were. |
|
I will have a look at it tomorrow. |
…d vector_finding.py
74cf197 to
320bad2
Compare
There was a problem hiding this comment.
Interestingly, I was expecting more changes to be required but clearly this is not the case. This look pretty good, most of my comments could handle here or in a follow up PR as they are improvement suggestion on simplifying user workflow and reducing redundancy.
| center, affine, params, pos, inlier = pxm.utils.ransac_ellipse_tools.determine_ellipse( | ||
| s, use_ransac=True, return_params=True | ||
| ) | ||
|
|
||
| el, in_points, out_points = pxm.utils.ransac_ellipse_tools.ellipse_to_markers( | ||
| ellipse_array=params, points=pos, inlier=inlier | ||
| ) |
There was a problem hiding this comment.
For the user, would it be more simple to have methods of the Diffraction2D signal, which would used these functions?
This sounds very verbose while user needs are:
- measure ellipticity (return affine transformation and ellipse markers)
- check measurement visually (use ellipse markers)
- correct ellipticity (use affine transformation)
There was a problem hiding this comment.
Yes! It's on the list of things to do 😅 There are lots of extra classes/ functionality which should be functions of signals.
There was a problem hiding this comment.
I added it to the list of things to do in #973
There was a problem hiding this comment.
When using the find_peaks method interactively, the markers are not displaying! This is most likely something that need to be fixed in hyperspy.
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
|
Yes, sounds good to me! |
name: Adjusting to Hyperspy 2.0.0 Changes
about: This makes pyxem compatible with hyperspy 2.0.0
Checklist
mapfunctionspeakandlinesegmentmarkersWhat does this PR do? Please describe and/or link to an open issue.
It might be a good idea to start by merging this after 0.16.0 is released and then try to clean up some of the changes.