8000 fix: suppress event loop errors during subprocess transport cleanup by yeisonvargasf · Pull Request #731 · pyupio/safety · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: suppress event loop errors during subprocess transport cleanup #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2025
Merged

fix: suppress event loop errors during subprocess transport cleanup #731

merged 1 commit into from
May 5, 2025

Conversation

yeisonvargasf
Copy link
Member

Fix RuntimeError when garbage collector tries to clean up subprocess transports after event loop closure. Affects multiple Python versions (3.8+) on both Windows and Unix platforms. Added patches to safely handle 'Event loop is closed' errors in BaseSubprocessTransport.del, _ProactorBasePipeTransport.del and others.

@coderabbitai coderabbitai
Copy link
coderabbitai bot commented May 5, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@yeisonvargasf yeisonvargasf self-assigned this May 5, 2025
@yeisonvargasf yeisonvargasf added the bug Indicates a problem that needs to be resolved. label May 5, 2025
@github-actions GitHub Actions
Copy link
github-actions bot commented May 5, 2025

🚀 Build artifacts are ready for testing!

Download the wheel file and binaries with gh CLI or from the workflow artifacts.

📦 Install & Run

Pre-requisites

# Install uv if needed
curl -LsSf https://astral.sh/uv/install.sh | sh

# Create and enter artifacts directory
mkdir artifacts && cd artifacts

Quick Test with Python Package

# Download and run with uv
gh run download 14844755850 -n dist -R pyupio/safety
uv run --with safety-3.4.1b0+fix.subprocess.exceptions-py3-none-any.whl safety --version

Binary Installation

# Linux
gh run download 14844755850 -n safety-linux -D linux -R pyupio/safety
cd linux && mv safety safety-pr && chmod +x safety-pr

# macOS
gh run download 14844755850 -n safety-macos -D macos -R pyupio/safety
cd macos && mv safety safety-pr && chmod +x safety-pr

# Windows
gh run download 14844755850 -n safety-windows -D windows -R pyupio/safety
cd windows && mv safety.exe safety-pr.exe

./safety-pr --version

Note: You need to be logged in to GitHub to access the artifacts.

@yeisonvargasf
fix: suppress event loop errors during subprocess transport cleanup
10aebd5 
Fix RuntimeError when garbage collector tries to clean up subprocess transports after event loop closure. Affects multiple Python versions (3.8+) on both Windows and Unix platforms. Added patches to safely handle 'Event loop is closed' errors in BaseSubprocessTransport.__del__, _ProactorBasePipeTransport.__del__ and others.
@yeisonvargasf yeisonvargasf force-pushed the fix/subprocess-exceptions branch from e0b9e46 to 10aebd5 Compare May 5, 2025 19:45
jakub-safetycli
jakub-safetycli approved these changes May 5, 2025
View reviewed changes
Copy link
Collaborator
@jakub-safetycli jakub-safetycli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yeisonvargasf yeisonvargasf merged commit 1e3519a into main May 5, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakub-safetycli jakub-safetycli jakub-safetycli approved these changes

Assignees

@yeisonvargasf yeisonvargasf

Labels
bug Indicates a problem that needs to be resolved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yeisonvargasf @jakub-safetycli
0