8000 fix: add compatibility for marshmallow 4.* by yeisonvargasf · Pull Request #713 · pyupio/safety · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: add compatibility for marshmallow 4.* #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2025
Merged

fix: add compatibility for marshmallow 4.* #713

merged 1 commit into from
Apr 17, 2025

Conversation

yeisonvargasf
Copy link
Member
@yeisonvargasf yeisonvargasf commented Apr 17, 2025 •
edited
Loading

Handles the case of marshmallow 4.*

This PR will fix #711, and it will be shipped in Safety CLI 3.4.0

@yeisonvargasf yeisonvargasf self-assigned this Apr 17, 2025
@coderabbitai coderabbitai
Copy link
coderabbitai bot commented Apr 17, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@yeisonvargasf yeisonvargasf added the enhancement Suggests an improvement or new feature. label Apr 17, 2025
@github-actions GitHub Actions
Copy link
github-actions bot commented Apr 17, 2025 •
edited
Loading

🚀 Build artifacts are ready for testing!

Download the wheel file and binaries with gh CLI or from the workflow artifacts.

📦 Install & Run

Pre-requisites

# Install uv if needed
curl -LsSf https://astral.sh/uv/install.sh | sh

# Create and enter artifacts directory
mkdir artifacts && cd artifacts

Quick Test with Python Package

# Download and run with uv
gh run download 14522842402 -n dist -R pyupio/safety
uv run --with safety-3.4.0b7+fix.marshmallow.rework-py3-none-any.whl safety --version

Binary Installation

# Linux
gh run download 14522842402 -n safety-linux -D linux -R pyupio/safety
cd linux && mv safety safety-pr && chmod +x safety-pr

# macOS
gh run download 14522842402 -n safety-macos -D macos -R pyupio/safety
cd macos && mv safety safety-pr && chmod +x safety-pr

# Windows
gh run download 14522842402 -n safety-windows -D windows -R pyupio/safety
cd windows && mv safety.exe safety-pr.exe

./safety-pr --version

Note: You need to be logged in to GitHub to access the artifacts.

@yeisonvargasf yeisonvargasf force-pushed the fix/marshmallow-rework branch 2 times, most recently from f110340 to c8fe78b Compare April 17, 2025 18:44
@yeisonvargasf yeisonvargasf force-pushed the fix/marshmallow-rework branch from c8fe78b to b013957 Compare April 17, 2025 18:59
@yeisonvargasf yeisonvargasf merged commit cece01a into main Apr 17, 2025
28 checks passed
@michael-cybrid
Copy link

Any update on when this will be released? Marshmallow 4 has been release so this is causing breakages.

@yeisonvargasf
Copy link
Member Author

Any update on when this will be released? Marshmallow 4 has been release so this is causing breakages.

This will be released in the next Safety CLI stable version hopefully next week (we may release beta versions with the fix this week). A workaround was shared on: #711 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidlacho davidlacho davidlacho approved these changes

@jakub-safetycli jakub-safetycli jakub-safetycli approved these changes

@nickste nickste Awaiting requested review from nickste

Assignees

@yeisonvargasf yeisonvargasf

Labels
enhancement Suggests an improvement or new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue: Safety check failing with error - Unhandled exception happened: post_dump() got an unexpected keyword argument 'pass_many'
4 participants
@yeisonvargasf @michael-cybrid @davidlacho @jakub-safetycli
0