8000 fix parsing of generic constraints with "===" by radoering · Pull Request #860 · python-poetry/poetry-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix parsing of generic constraints with "===" #860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2025
Merged

fix parsing of generic constraints with "===" #860

merged 1 commit into from
Apr 26, 2025

Conversation

radoering
Copy link
Member
@radoering radoering commented Apr 26, 2025 •
edited by sourcery-ai bot
Loading
  • Added tests for changed code.
  • Updated documentation for changed code.

Before, the marker sys_platform === "linux" had been parsed to

name == "sys_platform"
operator == "=="
value == "=linux"

which is obviously wrong.

Now it is parsed to

name == "sys_platform"
operator == "=="
value == "linux"

which is correct because "==" and "===" are the same for generic constraints.

Disclaimer: This does not change the fact that we do not support "===" for version constraints.

Summary by Sourcery

Fix the parsing of generic constraints to correctly handle the === operator as equivalent to ==.

Bug Fixes:

  • Correctly parse generic constraints that use the === operator.

Tests:

  • Add tests for parsing generic constraints and markers using the === operator.

@sourcery-ai Sourcery AI
Copy link
sourcery-ai bot commented Apr 26, 2025 •
edited
Loading

Reviewer's Guide by Sourcery

This pull request fixes an issue where the "===" operator in generic constraints was parsed incorrectly. The fix involves updating the regular expression to match "===" and modifying the parsing logic to treat "===" the same as "==" for generic constraints. New tests have been added to ensure correct parsing of "===".

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Update the regular expression for basic constraints to correctly match the "===" operator.
  • Modified the BASIC_CONSTRAINT regex pattern.
 src/poetry/core/constraints/generic/parser.py
Adjust the parsing logic to treat the "===" operator equivalently to "==" for generic constraints.
  • Updated the conditional logic in _parse_single_constraint to handle "===".
 src/poetry/core/constraints/generic/parser.py
Add new test cases to verify the correct parsing of generic constraints using the "===" operator.
  • Added test cases for sys_platform === "darwin" in test_markers.py.
  • Added a test case for ===win32 in test_main.py.
 tests/version/test_markers.py
tests/constraints/generic/test_main.py
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed Apr 26, 2025
View reviewed changes
Copy link
@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @radoering - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟡 Testing: 1 issue found
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@radoering radoering force-pushed the fix-parse-generic-arbitrary-equality branch from a246a9d to 316d4cc Compare April 26, 2025 08:50
@radoering radoering requested a review from a team April 26, 2025 09:08
@radoering radoering merged commit 7831ee8 into python-poetry:main Apr 26, 2025
18 checks passed
This was referenced May 4, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@Secrus Secrus Secrus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radoering @Secrus
0