10000 Make WheelBuilder easier to inherit from by MatthijsBurgh · Pull Request #855 · python-poetry/poetry-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Make WheelBuilder easier to inherit from #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 6, 2025
Merged

Make WheelBuilder easier to inherit from #855

merged 1 commit into from
Apr 6, 2025

Conversation

MatthijsBurgh
Copy link
Contributor
@MatthijsBurgh MatthijsBurgh commented Apr 5, 2025 •
edited by sourcery-ai bot
Loading

When inheriting from WheelBuilder, I also have to overwrite the make_in classmethod. As it always creates a WheelBuilder instead of using the current class. This small change doesn't affect your implementation. It just makes inheriting from it a little bit easier.

  • Added tests for changed code.
  • Updated documentation for changed code.

Summary by Sourcery

Enhancements:

  • Modify make_in classmethod to use cls() instead of directly instantiating WheelBuilder, making the class more flexible for inheritance

@sourcery-ai Sourcery AI
Copy link
sourcery-ai bot commented Apr 5, 2025 •
edited
Loading

Reviewer's Guide by Sourcery

This pull request modifies the make_in class method in the WheelBuilder class to instantiate the current class (cls) instead of always instantiating WheelBuilder. This change makes it easier to inherit from the WheelBuilder class without having to override the make_in method.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Modified the make_in class method to instantiate the current class instead of always instantiating WheelBuilder.
  • Changed WheelBuilder to cls when instantiating the wheel builder in the make_in method.
 src/poetry/core/masonry/builders/wheel.py
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed Apr 5, 2025
View reviewed changes
Copy link
@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @MatthijsBurgh - I've reviewed your changes - here's some feedback:

Overall Comments:

  • This change looks good, but it would be helpful to add a test case that specifically covers the inheritance scenario to ensure the make_in method works as expected in derived classes.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@radoering radoering merged commit 2528905 into python-poetry:main Apr 6, 2025
18 checks passed
@MatthijsBurgh MatthijsBurgh deleted the patch-1 branch April 7, 2025 06:56
@radoering radoering mentioned this pull request May 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@radoering radoering radoering approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MatthijsBurgh @radoering
0