8000 fix: create listener socket with specific IP version by agners · Pull Request #1557 · python-zeroconf/python-zeroconf · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: create listener socket with specific IP version #1557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 1, 2025
Merged

fix: create listener socket with specific IP version #1557

merged 2 commits into from
Apr 1, 2025

Conversation

agners
Copy link
Collaborator
@agners agners commented Apr 1, 2025

Create listener sockets when using unicast with specific IP version as well, just like in new_respond_socket().

@codspeed-hq CodSpeed HQ
Copy link
codspeed-hq bot commented Apr 1, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #1557 will not alter performance

Comparing agners:fix-ipversion-all-with-unicast (f16a922) with master (54eb383)

Summary

✅ 6 untouched benchmarks

@codecov Codecov
Copy link
codecov bot commented Apr 1, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.79%. Comparing base (54eb383) to head (f16a922).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1557   +/-   ##
=======================================
  Coverage   99.79%   99.79%           
=======================================
  Files          33       33           
  Lines        3392     3393    +1     
  Branches      463      463           
=======================================
+ Hits         3385     3386    +1     
  Misses          5        5           
  Partials        2        2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bdraco bdraco changed the title Create listener socket with specific IP version fix: create listener socket with specific IP version Apr 1, 2025
@bdraco
Copy link
Member
bdraco commented Apr 1, 2025

can you add a test (only if IPv6 is available.. there is a fixture already) that creates and IPv4 and IPv6 one with unicast?
8000

agners added 2 commits April 1, 2025 20:54
@agners
fix: create listener socket with specific IP version
d288a47 
Create listener sockets when using unicast with specific IP version
as well, just like in `new_respond_socket()`.
@agners
chore(tests): add unit test for socket creation with unicast addressing
f16a922
@agners agners force-pushed the fix-ipversion-all-with-unicast branch from c236aee to f16a922 Compare April 1, 2025 18:55
@bdraco bdraco merged commit b757ddf into python-zeroconf:master Apr 1, 2025
33 of 34 checks passed
@bdraco
Copy link
Member
bdraco commented Apr 1, 2025

Thanks @agners

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdraco bdraco bdraco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agners @bdraco
0