unpin cython #3269
Open
unpin cython #3269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3269 +/- ##
===============================================
Coverage 100.00000% 100.00000%
===============================================
Files 127 127
Lines 19259 19259
Branches 1301 1301
===============================================
Hits 19259 19259 🚀 New features to boost your workflow:
|
|
ah, I simply needed setuptools. The tox env isn't super pretty but I'm not sure it's worth trying to merge with the regular cython env, but it might be useful for testing / in the future if/when we integrate tox into CI. |
A5rocks
reviewed
May 19, 2025
| @@ -63,6 +63,26 @@ commands_pre = | |||
| commands = | |||
| python -m tests.cython.run_test_cython | |||
|
|
|||
| [testenv:cov-cython] | |||
There was a problem hiding this comment.
I would rather either have this in CI or delay this part of this PR until that point, so it doesn't get stale.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes part of #3267 with the release of https://github.com/cython/cython/releases/tag/3.1.1
I'm getting errors locally when I try to combine it with coverage, so I think there's more to be done, but let's see if CI errors as well
I did look at configuration options for coverage and tox and ultimately couldn't find a better option than
sedingpyproject.toml(as the CI setup does), though at least did it to a copy in the tox tmp/ directory to not screw with the git working tree.