Remove check_type_completeness and verify_types_*.json, minor fixes #2877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t --verifytypes directly into check.sh. Fix pyright type_tests location.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2877 +/- ##
==========================================
+ Coverage 99.51% 99.54% +0.02%
==========================================
Files 115 115
Lines 17683 17672 -11
Branches 3172 3167 -5
==========================================
- Hits 17598 17592 -6
+ Misses 56 52 -4
+ Partials 29 28 -1
|
Closed
41 tasks
TeamSpen210
approved these changes
Nov 14, 2023
A5rocks
approved these changes
Nov 15, 2023
I guess we could go with their suggestion of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src/trio/_tests/check_type_completeness.pyand it's tracking filessrc/trio/_tests/verify_types_*.jsonas they're no longer needed for tracking incremental progress.check_type_completeness.pycan be removed #2734, might sneak in another commit that removes autogeneration ofpy.typedas well.pyright --verifytypesdirectly intocheck.sh.trio/_tests/type_testsin pyright call incheck.sh. Turns out pyright returns with exit code 0 on missing files pyright gives exit code 0 on invalid file microsoft/pyright#6443--ignoreexternaland fixed some small things that popped up from it, but encountered verifytypes reports re-exported stdlib functions as missing docstrings microsoft/pyright#6442 as well as some other issues that made me drop it.src/trio/socket.pyCopied some formatting from mypy to get something into the github CI error summary, but this shouldn't fail as often so don't think it needs to be as fully decked out.