typing for decorators - fx/_compatibility #2322
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D61493706 |
aorenste
added a commit
to aorenste/executorch
that referenced
this pull request
Aug 21, 2024
Summary: Pull Request resolved: pytorch#4810 X-link: pytorch/torchrec#2322 X-link: pytorch/pytorch#134054 See #131429 Differential Revision: D61493706
aorenste
added a commit
to aorenste/pytorch
that referenced
this pull request
Aug 21, 2024
Summary: X-link: pytorch/executorch#4810 X-link: pytorch/torchrec#2322 Pull Request resolved: pytorch#134054 See pytorch#131429 Test Plan: unit tests pass Differential Revision: D61493706
|
This pull request was exported from Phabricator. Differential Revision: D61493706 |
ee7f433 to
c28410f
Compare
aorenste
added a commit
to aorenste/torchrec
that referenced
this pull request
Aug 21, 2024
Summary: X-link: pytorch/executorch#4810 Pull Request resolved: pytorch#2322 X-link: pytorch/pytorch#134054 See #131429 Differential Revision: D61493706
aorenste
added a commit
to aorenste/executorch
that referenced
this pull request
Aug 21, 2024
Summary: X-link: ctrl-labs/src2#33884 Pull Request resolved: pytorch#4810 X-link: pytorch/torchrec#2322 X-link: pytorch/pytorch#134054 See #131429 Differential Revision: D61493706
aorenste
added a commit
to aorenste/executorch
that referenced
this pull request
Aug 21, 2024
Summary: X-link: ctrl-labs/src2#33884 Pull Request resolved: pytorch#4810 X-link: pytorch/torchrec#2322 X-link: pytorch/pytorch#134054 See #131429 Differential Revision: D61493706
aorenste
added a commit
to aorenste/executorch
that referenced
this pull request
Aug 22, 2024
Summary: X-link: ctrl-labs/src2#33884 Pull Request resolved: pytorch#4810 X-link: pytorch/torchrec#2322 X-link: pytorch/pytorch#134054 See #131429 Differential Revision: D61493706
|
This pull request was exported from Phabricator. Differential Revision: D61493706 |
c28410f to
effbb1d
Compare
aorenste
added a commit
to aorenste/torchrec
that referenced
this pull request
Aug 22, 2024
Summary: X-link: ctrl-labs/src2#33884 X-link: pytorch/executorch#4810 Pull Request resolved: pytorch#2322 X-link: pytorch/pytorch#134054 See #131429 Differential Revision: D61493706
aorenste
added a commit
to aorenste/executorch
that referenced
this pull request
Aug 22, 2024
Summary: X-link: ctrl-labs/src2#33884 Pull Request resolved: pytorch#4810 X-link: pytorch/torchrec#2322 X-link: pytorch/pytorch#134054 See #131429 Differential Revision: D61493706
aorenste
added a commit
to aorenste/executorch
that referenced
this pull request
Aug 22, 2024
Summary: X-link: ctrl-labs/src2#33884 Pull Request resolved: pytorch#4810 X-link: pytorch/torchrec#2322 X-link: pytorch/pytorch#134054 See #131429 Differential Revision: D61493706
|
This pull request was exported from Phabricator. Differential Revision: D61493706 |
aorenste
added a commit
to aorenste/torchrec
that referenced
this pull request
Aug 22, 2024
Summary: X-link: ctrl-labs/src2#33884 X-link: pytorch/executorch#4810 Pull Request resolved: pytorch#2322 X-link: pytorch/pytorch#134054 See #131429 Differential Revision: D61493706
effbb1d to
da08401
Compare
aorenste
added a commit
to aorenste/pytorch
that referenced
this pull request
Aug 22, 2024
Summary: X-link: ctrl-labs/src2#33884 X-link: pytorch/executorch#4810 X-link: pytorch/torchrec#2322 Pull Request resolved: pytorch#134054 See pytorch#131429 Test Plan: unit tests pass Differential Revision: D61493706
aorenste
added a commit
to aorenste/executorch
that referenced
this pull request
Aug 22, 2024
Summary: X-link: ctrl-labs/src2#33884 Pull Request resolved: pytorch#4810 X-link: pytorch/torchrec#2322 X-link: pytorch/pytorch#134054 See #131429 Differential Revision: D61493706
aorenste
added a commit
to aorenste/pytorch
that referenced
this pull request
Aug 22, 2024
Summary: X-link: ctrl-labs/src2#33884 X-link: pytorch/executorch#4810 X-link: pytorch/torchrec#2322 Pull Request resolved: pytorch#134054 See pytorch#131429 Test Plan: unit tests pass Differential Revision: D61493706
aorenste
added a commit
to aorenste/executorch
that referenced
this pull request
Aug 23, 2024
Summary: X-link: ctrl-labs/src2#33884 Pull Request resolved: pytorch#4810 X-link: pytorch/torchrec#2322 X-link: pytorch/pytorch#134054 See #131429 Differential Revision: D61493706
|
This pull request was exported from Phabricator. Differential Revision: D61493706 |
da08401 to
d4d6c5a
Compare
aorenste
added a commit
to aorenste/torchrec
that referenced
this pull request
Aug 23, 2024
Summary: X-link: ctrl-labs/src2#33884 X-link: pytorch/executorch#4810 Pull Request resolved: pytorch#2322 X-link: pytorch/pytorch#134054 See #131429 Differential Revision: D61493706
pytorch-bot bot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Aug 23, 2024
Summary: X-link: ctrl-labs/src2#33884 X-link: pytorch/executorch#4810 X-link: pytorch/torchrec#2322 Pull Request resolved: #134054 See #131429 Test Plan: unit tests pass Differential Revision: D61493706
aorenste
added a commit
to aorenste/executorch
that referenced
this pull request
Aug 24, 2024
Summary: X-link: ctrl-labs/src2#33884 Pull Request resolved: pytorch#4810 X-link: pytorch/torchrec#2322 X-link: pytorch/pytorch#134054 See #131429 Differential Revision: D61493706
|
This pull request was exported from Phabricator. Differential Revision: D61493706 |
d4d6c5a to
3f1314a
Compare
aorenste
added a commit
to aorenste/torchrec
that referenced
this pull request
Aug 24, 2024
Summary: X-link: ctrl-labs/src2#33884 X-link: pytorch/executorch#4810 Pull Request resolved: pytorch#2322 X-link: pytorch/pytorch#134054 See #131429 Differential Revision: D61493706
aorenste
added a commit
to aorenste/pytorch
that referenced
this pull request
Aug 24, 2024
Summary: X-link: ctrl-labs/src2#33884 X-link: pytorch/executorch#4810 X-link: pytorch/torchrec#2322 Pull Request resolved: pytorch#134054 See pytorch#131429 Test Plan: unit tests pass Differential Revision: D61493706
aorenste
added a commit
to aorenste/executorch
that referenced
this pull request
Aug 24, 2024
Summary: X-link: ctrl-labs/src2#33884 Pull Request resolved: pytorch#4810 X-link: pytorch/torchrec#2322 X-link: pytorch/pytorch#134054 See #131429 Differential Revision: D61493706
|
This pull request was exported from Phabricator. Differential Revision: D61493706 |
3f1314a to
75c6d18
Compare
aorenste
added a commit
to aorenste/pytorch
that referenced
this pull request
Aug 24, 2024
Summary: X-link: ctrl-labs/src2#33884 X-link: pytorch/executorch#4810 X-link: pytorch/torchrec#2322 Pull Request resolved: pytorch#134054 See pytorch#131429 Test Plan: unit tests pass Differential Revision: D61493706
aorenste
added a commit
to aorenste/executorch
that referenced
this pull request
Aug 24, 2024
Summary: X-link: ctrl-labs/src2#33884 Pull Request resolved: pytorch#4810 X-link: pytorch/torchrec#2322 X-link: pytorch/pytorch#134054 See #131429 Reviewed By: laithsakka Differential Revision: D61493706
aorenste
added a commit
to aorenste/pytorch
that referenced
this pull request
Aug 24, 2024
Summary: X-link: ctrl-labs/src2#33884 X-link: pytorch/executorch#4810 X-link: pytorch/torchrec#2322 Pull Request resolved: pytorch#134054 See pytorch#131429 Test Plan: unit tests pass Reviewed By: laithsakka Differential Revision: D61493706
|
This pull request was exported from Phabricator. Differential Revision: D61493706 |
aorenste
added a commit
to aorenste/torchrec
that referenced
this pull request
Aug 24, 2024
Summary: X-link: ctrl-labs/src2#33884 X-link: pytorch/executorch#4810 Pull Request resolved: pytorch#2322 X-link: pytorch/pytorch#134054 See #131429 Reviewed By: laithsakka Differential Revision: D61493706
75c6d18 to
92e43b8
Compare
aorenste
added a commit
to aorenste/executorch
that referenced
this pull request
Aug 25, 2024
Summary: X-link: ctrl-labs/src2#33884 Pull Request resolved: pytorch#4810 X-link: pytorch/torchrec#2322 X-link: pytorch/pytorch#134054 See #131429 Reviewed By: laithsakka Differential Revision: D61493706
|
This pull request was exported from Phabricator. Differential Revision: D61493706 |
92e43b8 to
f94810d
Compare
aorenste
added a commit
to aorenste/torchrec
that referenced
this pull request
Aug 25, 2024
Summary: X-link: F438 ctrl-labs/src2#33884 X-link: pytorch/executorch#4810 Pull Request resolved: pytorch#2322 X-link: pytorch/pytorch#134054 See #131429 Reviewed By: laithsakka Differential Revision: D61493706
aorenste
added a commit
to aorenste/pytorch
that referenced
this pull request
Aug 25, 2024
Summary: X-link: ctrl-labs/src2#33884 X-link: pytorch/executorch#4810 X-link: pytorch/torchrec#2322 Pull Request resolved: pytorch#134054 See pytorch#131429 Test Plan: unit tests pass Reviewed By: laithsakka Differential Revision: D61493706
aorenste
added a commit
to aorenste/torchrec
that referenced
this pull request
Aug 25, 2024
Summary: X-link: ctrl-labs/src2#33884 X-link: pytorch/executorch#4810 Pull Request resolved: pytorch#2322 X-link: pytorch/pytorch#134054 See #131429 Reviewed By: laithsakka Differential Revision: D61493706
f94810d to
c4ec76d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61493706 |
aorenste
added a commit
to aorenste/executorch
that referenced
this pull request
Aug 25, 2024
Summary: X-link: ctrl-labs/src2#33884 Pull Request resolved: pytorch#4810 X-link: pytorch/torchrec#2322 X-link: pytorch/pytorch#134054 See #131429 Reviewed By: laithsakka Differential Revision: D61493706
aorenste
added a commit
to aorenste/pytorch
that referenced
this pull request
Aug 25, 2024
Summary: X-link: ctrl-labs/src2#33884 X-link: pytorch/executorch#4810 X-link: pytorch/torchrec#2322 Pull Request resolved: pytorch#134054 See pytorch#131429 Test Plan: unit tests pass Reviewed By: laithsakka Differential Revision: D61493706
Summary: X-link: ctrl-labs/src2#33884 X-link: pytorch/executorch#4810 Pull Request resolved: pytorch#2322 X-link: pytorch/pytorch#134054 See #131429 Reviewed By: laithsakka Differential Revision: D61493706
aorenste
added a commit
to aorenste/executorch
that referenced
this pull request
Aug 25, 2024
Summary: X-link: ctrl-labs/src2#33884 Pull Request resolved: pytorch#4810 X-link: pytorch/torchrec#2322 X-link: pytorch/pytorch#134054 See #131429 Reviewed By: laithsakka Differential Revision: D61493706
|
This pull request was exported from Phabricator. Differential Revision: D61493706 |
c4ec76d to
baff9ee
Compare
aorenste
added a commit
to aorenste/pytorch
that referenced
this pull request
Aug 25, 2024
Summary: X-link: ctrl-labs/src2#33884 X-link: pytorch/executorch#4810 X-link: pytorch/torchrec#2322 Pull Request resolved: pytorch#134054 See pytorch#131429 Test Plan: unit tests pass Reviewed By: laithsakka Differential Revision: D61493706
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: See #131429
Differential Revision: D61493706