8000 Refactored prim utils into _prims_utils folder by Chillee · Pull Request #81088 · pytorch/pytorch · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Refactored prim utils into _prims_utils folder #81088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 16 commits into from
Closed

Refactored prim utils into _prims_utils folder #81088

wants to merge 16 commits into from

Conversation

Chillee
Copy link
Collaborator
@Chillee Chillee commented Jul 8, 2022 •
edited
Loading

This was referenced Jul 8, 2022
Closed
Closed
Closed
@facebook-github-bot
Copy link
Contributor
facebook-github-bot commented Jul 8, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 1be6e72 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@Chillee Chillee changed the title Refactored prim utils into _prims_utils folder [WIP?] Refactored prim utils into _prims_utils folder Jul 8, 2022
@Chillee Chillee changed the title [WIP?] Refactored prim utils into _prims_utils folder [doesn't work] Refactored prim utils into _prims_utils folder Jul 8, 2022
This was referenced Jul 8, 2022
Closed
Closed
@Chillee Chillee changed the title [doesn't work] Refactored prim utils into _prims_utils folder Refactored prim utils into _prims_utils folder Jul 15, 2022
@Chillee
Copy link
Collaborator Author
Chillee commented Jul 15, 2022

For the most part, this is a mechanical change, moving _prims/utils.py and _prims/wrappers.py to _prims_common and updating imports.

2 non-trivial changes:

  1. I moved get_prim_fake_mode and TensorMeta into _prims/__init__.py.
  2. I updated the prims calls in _prims_common/wrappers.py to call torch ops instead (with the exception of copy_to, which I changed to a lazy import).

@Chillee Chillee requested review from mruberry, ezyang and ngimel and removed request for mruberry July 15, 2022 23:13
ngimel
ngimel reviewed Jul 15, 2022
View reviewed changes
torch/_prims_common/__init__.py Outdated
@@ -241,140 +160,6 @@ def is_contiguous(a: TensorLikeType) -> bool:
return True


# This function is equivalent to compute_channels_last_contiguous_2d() in TensorImpl.cpp
def is_channels_last_contiguous_2d(a: Tensor) -> bool:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where did all these functions go?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hrmm, I suspect a recent merge failure.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh ok, I think constant_pad_nd was reverted

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the issue.

@Chillee Chillee mentioned this pull request Jul 18, 2022
Closed
@Chillee
Copy link
Collaborator Author
Chillee commented Jul 19, 2022

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Contributor

Hey @Chillee.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@jeanschmidt
Copy link
Contributor

@pytorchbot revert this please

@pytorch-bot
Copy link
pytorch-bot bot commented Jul 19, 2022

❌ 🤖 pytorchbot command failed:

@pytorchbot revert: error: the following arguments are required: -m/--message, -c/--classification

usage: @pytorchbot revert -m MESSAGE -c
                          {nosignal,ignoredsignal,landrace,weird,ghfirst}

Try @pytorchbot --help for more info.

@jeanschmidt
Copy link
Contributor

@pytorchbot revert -m "braking internal builds"

@pytorch-bot
Copy link
pytorch-bot bot commented Jul 19, 2022

❌ 🤖 pytorchbot command failed:

@pytorchbot revert: error: the following arguments are required: -c/--classification

usage: @pytorchbot revert -m MESSAGE -c
                          {nosignal,ignoredsignal,landrace,weird,ghfirst}

Try @pytorchbot --help for more info.

@jeanschmidt
Copy link
Contributor

@pytorchbot revert -m="breaking internal tests" -c=nosignal

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

@Chillee your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request Jul 19, 2022
@pytorchmergebot
Revert "Refactored prim utils into _prims_utils folder (#81088)"
e43a02c 
This reverts commit 80231d0.

Reverted #81088 on behalf of https://github.com/jeanschmidt due to breaking internal tests
@Chillee
Copy link
Collaborator Author
Chillee commented Jul 19, 2022

@jeanschmidt what's the failure?

@kit1980
Copy link
Contributor
kit1980 commented Jul 19, 2022

what's the failure?

See D37957414

Chillee added a commit that referenced this pull request Jul 20, 2022
@Chillee
Revert "Revert "Refactored prim utils into _prims_utils folder (#81088)…
7d30da7 
…""

This reverts commit e43a02c.

[ghstack-poisoned]
Chillee added a commit that referenced this pull request Jul 20, 2022
@Chillee
Revert "Revert "Refactored prim utils into _prims_utils folder (#81088)…
930e51b 
…""

This reverts commit e43a02c.

ghstack-source-id: be23773
Pull Request resolved: #81745
Chillee added a commit that referenced this pull request Jul 20, 2022
@Chillee
Revert "Revert "Refactored prim utils into _prims_utils folder (#81088)…
5a8e8a3 
…""

This reverts commit e43a02c.

ghstack-source-id: be23773
Pull Request resolved: #81745
Chillee added a commit that referenced this pull request Jul 20, 2022
@Chillee
Revert "Revert "Refactored prim utils into _prims_utils folder (#81088)…
43604d0 
…""

This reverts commit e43a02c.

ghstack-source-id: be23773
Pull Request resolved: #81745
@facebook-github-bot facebook-github-bot deleted the gh/chillee/72/head branch July 22, 2022 14:19
@janeyx99 janeyx99 mentioned this pull request Jul 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngimel ngimel ngimel approved these changes

@ezyang ezyang Awaiting requested review from ezyang

@mruberry mruberry Awaiting requested review from mruberry

Assignees
No one assigned
Labels
cla signed Merged Reverted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Chillee @facebook-github-bot @pytorchmergebot @jeanschmidt @kit1980 @ngimel
0