8000 [Profiler] Handle events from Kineto in the unified result class. by robieta · Pull Request #80797 · pytorch/pytorch · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Profiler] Handle events from Kineto in the unified result class. #80797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 27 commits into from
Closed

[Profiler] Handle events from Kineto in the unified result class. #80797

wants to merge 27 commits into from

Conversation

robieta
Copy link
@robieta robieta commented Jul 2, 2022 •
edited
Loading

Stack from ghstack (oldest at bottom):

At long last, torch::profiler::impl::Result can handle all data for the profiler. The principle change is that collection.cpp now extracts events that Kineto collected rather than profiler_kineto.cpp, and there is now an ExtraFields<Kineto> type added to the Result variant.

Differential Revision: D37406956

[Profiler] Handle events from Kineto in the unified result class.
e54f751 
At long last, `torch::profiler::impl::Result` can handle all data for the profiler. The principle change is that `collection.cpp` now extracts events that Kineto collected rather than `profiler_kineto.cpp`, and there is now an `ExtraFields<Kineto>` type added to the Result variant.

Differential Revision: [D37406956](https://our.internmc.facebook.com/intern/diff/D37406956/)

[ghstack-poisoned]
@robieta robieta requested review from albanD and soulitzer as code owners July 2, 2022 20:41
@facebook-github-bot
Copy link
Contributor
facebook-github-bot commented Jul 2, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 2cb5879 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

This was referenced Jul 2, 2022
Closed
Closed
Closed
Closed
robieta pushed a commit that referenced this pull request Jul 2, 2022
[Profiler] Handle events from Kineto in the unified result class.
34a3f2a 
At long last, `torch::profiler::impl::Result` can handle all data for the profiler. The principle change is that `collection.cpp` now extracts events that Kineto collected rather than `profiler_kineto.cpp`, and there is now an `ExtraFields<Kineto>` type added to the Result variant.

Differential Revision: [D37406956](https://our.internmc.facebook.com/intern/diff/D37406956/)

ghstack-source-id: 160534632
Pull Request resolved: #80797
Update on "[Profiler] Handle events from Kineto in the unified result…
45e4da6 
… class."

At long last, `torch::profiler::impl::Result` can handle all data for the profiler. The principle change is that `collection.cpp` now extracts events that Kineto collected rather than `profiler_kineto.cpp`, and there is now an `ExtraFields<Kineto>` type added to the Result variant.

Differential Revision: [D37406956](https://our.internmc.facebook.com/intern/diff/D37406956/)

[ghstack-poisoned]
@robieta robieta mentioned this pull request Jul 3, 2022
Closed
robieta pushed a commit that referenced this pull request Jul 3, 2022
[Profiler] Handle events from Kineto in the unified result class.
2bb116d 
Pull Request resolved: #80797

At long last, `torch::profiler::impl::Result` can handle all data for the profiler. The principle change is that `collection.cpp` now extracts events that Kineto collected rather than `profiler_kineto.cpp`, and there is now an `ExtraFields<Kineto>` type added to the Result variant.
ghstack-source-id: 160544694

Differential Revision: [D37406956](https://our.internmc.facebook.com/intern/diff/D37406956/)
@robieta robieta mentioned this pull request Jul 3, 2022
Closed
Update on "[Profiler] Handle events from Kineto in the unified result…
fe1a9b7 
… class."

At long last, `torch::profiler::impl::Result` can handle all data for the profiler. The principle change is that `collection.cpp` now extracts events that Kineto collected rather than `profiler_kineto.cpp`, and there is now an `ExtraFields<Kineto>` type added to the Result variant.

Differential Revision: [D37406956](https://our.internmc.facebook.com/intern/diff/D37406956/)

[ghstack-poisoned]
@robieta robieta requested review from chaekit and aaronenyeshi and removed request for albanD and soulitzer July 3, 2022 22:45
Taylor Robie added 2 commits July 6, 2022 10:08
Update on "[Profiler] Handle events from Kineto in the unified result…
ef89cfc 
… class."

At long last, `torch::profiler::impl::Result` can handle all data for the profiler. The principle change is that `collection.cpp` now extracts events that Kineto collected rather than `profiler_kineto.cpp`, and there is now an `ExtraFields<Kineto>` type added to the Result variant.

Differential Revision: [D37406956](https://our.internmc.facebook.com/intern/diff/D37406956/)

[ghstack-poisoned]
Update on "[Profiler] Handle events from Kineto in the unified result…
739dbe0 
… class."

At long last, `torch::profiler::impl::Result` can handle all data for the profiler. The principle change is that `collection.cpp` now extracts events that Kineto collected rather than `profiler_kineto.cpp`, and there is now an `ExtraFields<Kineto>` type added to the Result variant.

Differential Revision: [D37406956](https://our.internmc.facebook.com/intern/diff/D37406956/)

[ghstack-poisoned]
This was referenced Jul 12, 2022
Closed
Closed
Closed
Closed
@robieta robieta added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 12, 2022
Update on "[Profiler] Handle events from Kineto in the unified result…
86020cb 
… class."

At long last, `torch::profiler::impl::Result` can handle all data for the profiler. The principle change is that `collection.cpp` now extracts events that Kineto collected rather than `profiler_kineto.cpp`, and there is now an `ExtraFields<Kineto>` type added to the Result variant.

Differential Revision: [D37406956](https://our.internmc.facebook.com/intern/diff/D37406956/)

[ghstack-poisoned]
robieta pushed a commit that referenced this pull request Jul 15, 2022
[Profiler] Handle events from Kineto in the unified result class.
71b7485 
Pull Request resolved: #80797

At long last, `torch::profiler::impl::Result` can handle all data for the profiler. The principle change is that `collection.cpp` now extracts events that Kineto collected rather than `profiler_kineto.cpp`, and there is now an `ExtraFields<Kineto>` type added to the Result variant.
ghstack-source-id: 161652344

Differential Revision: [D37406956](https://our.internmc.facebook.com/intern/diff/D37406956/)
robieta pushed a commit that referenced this pull request Jul 25, 2022
Update on "[Profiler] Improve tree testing"
af3812f 
In the course of trying to get #80797 out the door, I've wound up making a number of minor tweaks to `test_profiler_tree` which collectively have made it much easier to debug. It's also revealed what seems to be a correctness issue with how profiler assigns lineage on certain platforms. So I've decided to pull those testing improvements into a standalone PR.

Differential Revision: [D38038122](https://our.internmc.facebook.com/intern/diff/D38038122/)

[ghstack-poisoned]
Update on "[Profiler] Handle events from Kineto in the unified result…
7db21c5 
… class."

At long last, `torch::profiler::impl::Result` can handle all data for the profiler. The principle change is that `collection.cpp` now extracts events that Kineto collected rather than `profiler_kineto.cpp`, and there is now an `ExtraFields<Kineto>` type added to the Result variant.

Differential Revision: [D37406956](https://our.internmc.facebook.com/intern/diff/D37406956/)

[ghstack-poisoned]
robieta pushed a commit that referenced this pull request Jul 28, 2022
Update base for Update on "[Profiler] Improve tree testing"
9960a42 
In the course of trying to get #80797 out the door, I've wound up making a number of minor tweaks to `test_profiler_tree` which collectively have made it much easier to debug. It's also revealed what seems to be a correctness issue with how profiler assigns lineage on certain platforms. So I've decided to pull those testing improvements into a standalone PR.

Differential Revision: [D38038122](https://our.internmc.facebook.com/intern/diff/D38038122/)

[ghstack-poisoned]
robieta pushed a commit that referenced this pull request Jul 28, 2022
Update on "[Profiler] Improve tree testing"
9bb07ad 
In the course of trying to get #80797 out the door, I've wound up making a number of minor tweaks to `test_profiler_tree` which collectively have made it much easier to debug. It's also revealed what seems to be a correctness issue with how profiler assigns lineage on certain platforms. So I've decided to pull those testing improvements into a standalone PR.

Differential Revision: [D38038122](https://our.internmc.facebook.com/intern/diff/D38038122/)

[ghstack-poisoned]
Update on "[Profiler] Handle events from Kineto in the unified result…
60ebcd7 
… class."

At long last, `torch::profiler::impl::Result` can handle all data for the profiler. The principle change is that `collection.cpp` now extracts events that Kineto collected rather than `profiler_kineto.cpp`, and there is now an `ExtraFields<Kineto>` type added to the Result variant.

Differential Revision: [D37406956](https://our.internmc.facebook.com/intern/diff/D37406956/)

[ghstack-poisoned]
robieta pushed a commit that referenced this pull request Jul 28, 2022
Update base for Update on "[Profiler] Improve tree testing"
5385a48 
In the course of trying to get #80797 out the door, I've wound up making a number of minor tweaks to `test_profiler_tree` which collectively have made it much easier to debug. It's also revealed what seems to be a correctness issue with how profiler assigns lineage on certain platforms. So I've decided to pull those testing improvements into a standalone PR.

Differential Revision: [D38038122](https://our.internmc.facebook.com/intern/diff/D38038122/)

[ghstack-poisoned]
robieta pushed a commit that referenced this pull request Jul 28, 2022
Update on "[Profiler] Improve tree testing"
9545b7a 
In the course of trying to get #80797 out the door, I've wound up making a number of minor tweaks to `test_profiler_tree` which collectively have made it much easier to debug. It's also revealed what seems to be a correctness issue with how profiler assigns lineage on certain platforms. So I've decided to pull those testing improvements into a standalone PR.

Differential Revision: [D38038122](https://our.internmc.facebook.com/intern/diff/D38038122/)

[ghstack-poisoned]
pytorchmergebot pushed a commit that referenced this pull request Jul 29, 2022
@pytorchmergebot
[Profiler] Improve tree testing (#81895)
54cae09 
In the course of trying to get #80797 out the door, I've wound up making a number of minor tweaks to `test_profiler_tree` which collectively have made it much easier to debug. It's also revealed what seems to be a correctness issue with how profiler assigns lineage on certain platforms. So I've decided to pull those testing improvements into a standalone PR.

Differential Revision: [D38038122](https://our.internmc.facebook.com/intern/diff/D38038122/)
Pull Request resolved: #81895
Approved by: https://github.com/slgong-fb, https://github.com/davidchencsl
pytorchmergebot pushed a commit that referenced this pull request Jul 29, 2022
@pytorchmergebot
[Profiler] Improve tree testing (#81895)
8d14b06 
In the course of trying to get #80797 out the door, I've wound up making a number of minor tweaks to `test_profiler_tree` which collectively have made it much easier to debug. It's also revealed what seems to be a correctness issue with how profiler assigns lineage on certain platforms. So I've decided to pull those testing improvements into a standalone PR.

Differential Revision: [D38038122](https://our.internmc.facebook.com/intern/diff/D38038122/)
Pull Request resolved: #81895
Approved by: https://github.com/slgong-fb, https://github.com/davidchencsl
Update on "[Profiler] Handle events from Kineto in the unified result…
2cb5879 
… class."

At long last, `torch::profiler::impl::Result` can handle all data for the profiler. The principle change is that `collection.cpp` now extracts events that Kineto collected rather than `profiler_kineto.cpp`, and there is now an `ExtraFields<Kineto>` type added to the Result variant.

Differential Revision: [D37406956](https://our.internmc.facebook.com/intern/diff/D37406956/)

[ghstack-poisoned]
robieta pushed a commit that referenced this pull request Jul 29, 2022
Update base for Update on "[Profiler] Improve tree testing"
02c77df 
In the course of trying to get #80797 out the door, I've wound up making a number of minor tweaks to `test_profiler_tree` which collectively have made it much easier to debug. It's also revealed what seems to be a correctness issue with how profiler assigns lineage on certain platforms. So I've decided to pull those testing improvements into a standalone PR.

Differential Revision: [D38038122](https://our.internmc.facebook.com/intern/diff/D38038122/)

[ghstack-poisoned]
robieta pushed a commit that referenced this pull request Jul 29, 2022
Update on "[Profiler] Improve tree testing"
cc58dda 
In the course of trying to get #80797 out the door, I've wound up making a number of minor tweaks to `test_profiler_tree` which colle
8000
ctively have made it much easier to debug. It's also revealed what seems to be a correctness issue with how profiler assigns lineage on certain platforms. So I've decided to pull those testing improvements into a standalone PR.

Differential Revision: [D38038122](https://our.internmc.facebook.com/intern/diff/D38038122/)

[ghstack-poisoned]
@robieta robieta added the release notes: profiler release notes category label Jul 29, 2022
@robieta
Copy link
Author
robieta commented Jul 29, 2022

@pytorchbot merge -l

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Contributor

Hey @robieta.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

robieta pushed a commit that referenced this pull request Jul 30, 2022
Update base for Update on "[Profiler] Improve tree testing"
2a4f58f 
In the course of trying to get #80797 out the door, I've wound up making a number of minor tweaks to `test_profiler_tree` which collectively have made it much easier to debug. It's also revealed what seems to be a correctness issue with how profiler assigns lineage on certain platforms. So I've decided to pull those testing improvements into a standalone PR.

Differential Revision: [D38038122](https://our.internmc.facebook.com/intern/diff/D38038122/)

[ghstack-poisoned]
robieta pushed a commit that referenced this pull request Jul 30, 2022
Update on "[Profiler] Improve tree testing"
d9d1f07 
In the course of trying to get #80797 out the door, I've wound up making a number of minor tweaks to `test_profiler_tree` which collectively have made it much easier to debug. It's also revealed what seems to be a correctness issue with how profiler assigns lineage on certain platforms. So I've decided to pull those testing improvements into a standalone PR.

Differential Revision: [D38038122](https://our.internmc.facebook.com/intern/diff/D38038122/)

[ghstack-poisoned]
robieta pushed a commit that referenced this pull request Jul 30, 2022
Update base for Update on "[Profiler] Improve tree testing"
2bacb46 
In the course of trying to get #80797 out the door, I've wound up making a number of minor tweaks to `test_profiler_tree` which collectively have made it much easier to debug. It's also revealed what seems to be a correctness issue with how profiler assigns lineage on certain platforms. So I've decided to pull those testing improvements into a standalone PR.

Differential Revision: [D38038122](https://our.internmc.facebook.com/intern/diff/D38038122/)

[ghstack-poisoned]
robieta pushed a commit that referenced this pull request Jul 30, 2022
Update on "[Profiler] Improve tree testing"
cf47356 
In the course of trying to get #80797 out the door, I've wound up making a number of minor tweaks to `test_profiler_tree` which collectively have made it much easier to debug. It's also revealed what seems to be a correctness issue with how profiler assigns lineage on certain platforms. So I've decided to pull those testing improvements into a standalone PR.

Differential Revision: [D38038122](https://our.internmc.facebook.com/intern/diff/D38038122/)

[ghstack-poisoned]
robieta pushed a commit that referenced this pull request Jul 31, 2022
Update base for Update on "[Profiler] Improve tree testing"
944d82e 
In the course of trying to get #80797 out the door, I've wound up making a number of minor tweaks to `test_profiler_tree` which collectively have made it much easier to debug. It's also revealed what seems to be a correctness issue with how profiler assigns lineage on certain platforms. So I've decided to pull those testing improvements into a standalone PR.

Differential Revision: [D38038122](https://our.internmc.facebook.com/intern/diff/D38038122/)

[ghstack-poisoned]
robieta pushed a commit that referenced this pull request Jul 31, 2022
Update on "[Profiler] Improve tree testing"
9591165 
In the course of trying to get #80797 out the door, I've wound up making a number of minor tweaks to `test_profiler_tree` which collectively have made it much easier to debug. It's also revealed what seems to be a correctness issue with how profiler assigns lineage on certain platforms. So I've decided to pull those testing improvements into a standalone PR.

Differential Revision: [D38038122](https://our.internmc.facebook.com/intern/diff/D38038122/)

[ghstack-poisoned]
robieta pushed a commit that referenced this pull request Jul 31, 2022
Update base for Update on "[Profiler] Improve tree testing"
d98c345 
In the course of trying to get #80797 out the door, I've wound up making a number of minor tweaks to `test_profiler_tree` which collectively have made it much easier to debug. It's also revealed what seems to be a correctness issue with how profiler assigns lineage on certain platforms. So I've decided to pull those testing improvements into a standalone PR.

Differential Revision: [D38038122](https://our.internmc.facebook.com/intern/diff/D38038122/)

[ghstack-poisoned]
robieta pushed a commit that referenced this pull request Jul 31, 2022
Update on "[Profiler] Improve tree testing"
b34a968 
In the course of trying to get #80797 out the door, I've wound up making a number of minor tweaks to `test_profiler_tree` which collectively have made it much easier to debug. It's also revealed what seems to be a correctness issue with how profiler assigns lineage on certain platforms. So I've decided to pull those testing improvements into a standalone PR.

Differential Revision: [D38038122](https://our.internmc.facebook.com/intern/diff/D38038122/)

[ghstack-poisoned]
facebook-github-bot pushed a commit that referenced this pull request Aug 1, 2022
@facebook-github-bot
[Profiler] Improve tree testing (#81895) (#81895)
6e888d8 
Summary:
In the course of trying to get #80797 out the door, I've wound up making a number of minor tweaks to `test_profiler_tree` which collectively have made it much easier to debug. It's also revealed what seems to be a correctness issue with how profiler assigns lineage on certain platforms. So I've decided to pull those testing improvements into a standalone PR.

Pull Request resolved: #81895
Approved by: https://github.com/slgong-fb, https://github.com/davidchencsl

Test Plan:
contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/8d14b06c059548a969db360e50d13cf76e394bff

Original Phabricator Test Plan:
$ EXPECTTEST_ACCEPT=1 buck run mode/opt //caffe2/test:profiler -- -r test_profiler_experimental_tree

Reviewed By: osalpekar, slgong-fb

Differential Revision: D38038122

Pulled By: robieta

fbshipit-source-id: 5453226849223f9e8dca527627877ae2b5d9e7b3
facebook-github-bot pushed a commit that referenced this pull request Aug 1, 2022
@facebook-github-bot
[Profiler] Handle events from Kineto in the unified result class. (#8…
0174dc3 
…0797) (#80797)

Summary:
At long last, `torch::profiler::impl::Result` can handle all data for the profiler. The principle change is that `collection.cpp` now extracts events that Kineto collected rather than `profiler_kineto.cpp`, and there is now an `ExtraFields<Kineto>` type added to the Result variant.

Pull Request resolved: #80797
Approved by: https://github.com/aaronenyeshi

Test Plan:
contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/61b21f28d87cce11c5d25ee252b63906bd6e0b20

Original Phabricator Test Plan:
Added a unit test to `test_profiler_tree`

Reviewed By: aaronenyeshi, osalpekar

Differential Revision: D37406956

Pulled By: robieta

fbshipit-source-id: 7109d07b066d9defbb09e60858577efd55a4e220
@ptrblck ptrblck mentioned this pull request Aug 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronenyeshi aaronenyeshi aaronenyeshi approved these changes

@chaekit chaekit Awaiting requested review from chaekit

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request cla signed Merged release notes: profiler release notes category with-ssh
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@robieta @facebook-github-bot @pytorchmergebot @aaronenyeshi
0