8000 Support CSR to COO conversion in to_sparse. by pearu · Pull Request #73471 · pytorch/pytorch · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Support CSR to COO conversion in to_sparse. #73471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Support CSR to COO conversion in to_sparse. #73471

wants to merge 1 commit into from

Conversation

pearu
Copy link
Collaborator
@pearu pearu commented Feb 26, 2022 •
edited by cpuhrsch
Loading

@pearu pearu requested a review from ezyang as a code owner February 26, 2022 14:47
@pearu pearu mentioned this pull request Feb 26, 2022
Closed
@pytorch-bot
Copy link
pytorch-bot bot commented Feb 26, 2022
CI Flow Status

⚛️ CI Flow

Ruleset - Version: v1
Ruleset - File: https://github.com/pytorch/pytorch/blob/9f45271255b0e9e8f15f76c3088630a5fb965578/.github/generated-ciflow-ruleset.json
PR ciflow labels: ciflow/default
Add ciflow labels to this PR to trigger more builds:

Workflows Labels (bold enabled) Status
Triggered Workflows
linux-binary-conda ciflow/binaries, ciflow/binaries_conda, ciflow/default ✅ triggered
linux-binary-libtorch-cxx11-abi ciflow/binaries, ciflow/binaries_libtorch, ciflow/default ✅ triggered
linux-binary-libtorch-pre-cxx11 ciflow/binaries, ciflow/binaries_libtorch, ciflow/default ✅ triggered
linux-binary-manywheel ciflow/binaries, ciflow/binaries_wheel, ciflow/default ✅ triggered
linux-bionic-py3.7-clang9 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/noarch, ciflow/trunk ✅ triggered
linux-bionic-rocm4.5-py3.7 ciflow/all, ciflow/default, ciflow/linux, ciflow/rocm, ciflow/trunk ✅ triggered
linux-docs ciflow/all, ciflow/cpu, ciflow/default, ciflow/docs, ciflow/linux, ciflow/trunk ✅ triggered
linux-vulkan-bionic-py3.7-clang9 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk, ciflow/vulkan ✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7-bazel-test ciflow/all, ciflow/bazel, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
linux-xenial-py3-clang5-mobile-build ciflow/all, ciflow/default, ciflow/linux, ciflow/mobile, ciflow/trunk ✅ triggered
linux-xenial-py3-clang5-mobile-custom-build-static ciflow/all, ciflow/default, ciflow/linux, ciflow/mobile, ciflow/trunk ✅ triggered
linux-xenial-py3.7-clang7-asan ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/sanitizers, ciflow/trunk ✅ triggered
linux-xenial-py3.7-clang7-onnx ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/onnx, ciflow/trunk ✅ triggered
linux-xenial-py3.7-gcc5.4 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
linux-xenial-py3.7-gcc7 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
linux-xenial-py3.7-gcc7-no-ops ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
macos-arm64-binary-conda ciflow/binaries, ciflow/binaries_conda, ciflow/default ✅ triggered
macos-arm64-binary-wheel ciflow/binaries, ciflow/binaries_wheel, ciflow/default ✅ triggered
macos-binary-conda ciflow/binaries, ciflow/binaries_conda, ciflow/default ✅ triggered
macos-binary-libtorch-cxx11-abi ciflow/binaries, ciflow/binaries_libtorch, ciflow/default ✅ triggered
macos-binary-libtorch-pre-cxx11 ciflow/binaries, ciflow/binaries_libtorch, ciflow/default ✅ triggered
macos-binary-wheel ciflow/binaries, ciflow/binaries_wheel, ciflow/default ✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single ciflow/all, ciflow/android, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single-full-jit ciflow/all, ciflow/android, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
win-vs2019-cpu-py3 ciflow/all, ciflow/cpu, ciflow/default, ciflow/trunk, ciflow/win ✅ triggered
win-vs2019-cuda11.3-py3 ciflow/all, ciflow/cuda, ciflow/default, ciflow/trunk, ciflow/win ✅ triggered
windows-binary-libtorch-cxx11-abi ciflow/binaries, ciflow/binaries_libtorch, ciflow/default ✅ triggered
windows-binary-libtorch-pre-cxx11 ciflow/binaries, ciflow/binaries_libtorch, ciflow/default ✅ triggered
windows-binary-wheel ciflow/binaries, ciflow/binaries_wheel, ciflow/default ✅ triggered
Skipped Workflows
caffe2-linux-xenial-py3.7-gcc5.4 ciflow/all, ciflow/cpu, ciflow/linux, ciflow/trunk 🚫 skipped
docker-builds ciflow/all, ciflow/trunk 🚫 skipped
ios-12-5-1-arm64 ciflow/all, ciflow/ios, ciflow/macos, ciflow/scheduled 🚫 skipped
ios-12-5-1-arm64-coreml ciflow/all, ciflow/ios, ciflow/macos, ciflow/scheduled 🚫 skipped
ios-12-5-1-arm64-custom-ops ciflow/all, ciflow/ios, ciflow/macos, ciflow/scheduled 🚫 skipped
ios-12-5-1-arm64-metal ciflow/all, ciflow/ios, ciflow/macos, ciflow/scheduled 🚫 skipped
ios-12-5-1-x86-64 ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk 🚫 skipped
ios-12-5-1-x86-64-coreml ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk 🚫 skipped
libtorch-linux-xenial-cuda10.2-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux, ciflow/trunk 🚫 skipped
libtorch-linux-xenial-cuda11.3-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux, ciflow/trunk 🚫 skipped
linux-bionic-cuda10.2-py3.9-gcc7 ciflow/all, ciflow/cuda, ciflow/linux, ciflow/slow, ciflow/trunk 🚫 skipped
linux-docs-push ciflow/all, ciflow/cpu, ciflow/linux, ciflow/scheduled 🚫 skipped
linux-xenial-cuda11.3-py3.7-gcc7-no-ops ciflow/all, ciflow/cuda, ciflow/linux, ciflow/trunk 🚫 skipped
macos-10-15-py3-arm64 ciflow/all, ciflow/macos, ciflow/trunk 🚫 skipped
macos-10-15-py3-lite-interpreter-x86-64 ciflow/all, ciflow/macos, ciflow/trunk 🚫 skipped
macos-11-py3-x86-64 ciflow/all, ciflow/macos, ciflow/trunk 🚫 skipped
parallelnative-linux-xenial-py3.7-gcc5.4 ciflow/all, ciflow/cpu, ciflow/linux, ciflow/trunk 🚫 skipped
periodic-libtorch-linux-bionic-cuda11.5-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux, ciflow/scheduled 🚫 skipped
periodic-linux-bionic-cuda11.5-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/linux, ciflow/scheduled 🚫 skipped
periodic-linux-xenial-cuda10.2-py3-gcc7-slow-gradcheck ciflow/all, ciflow/cuda, ciflow/linux, ciflow/scheduled, ciflow/slow, ciflow/slow-gradcheck 🚫 skipped
periodic-linux-xenial-cuda11.3-py3.7-gcc7-debug ciflow/all, ciflow/cuda, ciflow/linux, ciflow/scheduled 🚫 skipped
periodic-win-vs2019-cuda11.5-py3 ciflow/all, ciflow/cuda, ciflow/scheduled, ciflow/win 🚫 skipped
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-build ciflow/all, ciflow/android, ciflow/cpu, ciflow/linux, ciflow/trunk 🚫 skipped
pytorch-xla-linux-bionic-py3.7-clang8 ciflow/all, ciflow/cpu, ciflow/linux, ciflow/trunk, ciflow/xla 🚫 skipped

@pearu pearu mentioned this pull request Feb 26, 2022
Closed
@facebook-github-bot
Copy link
Contributor
facebook-github-bot commented Feb 26, 2022 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 9f45271 (more details on the Dr. CI page):

✅ None of the CI failures appear to be your fault 💚

🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD
This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@pearu pearu self-assigned this Feb 26, 2022
@pearu pearu added module: sparse Related to torch.sparse open source release notes: sparse release notes category topic: new features topic category labels Feb 26, 2022
@pearu pearu requested a review from cpuhrsch February 26, 2022 14:49
@cpuhrsch
Copy link
Contributor

@cpuhrsch has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot pushed a commit that referenced this pull request Mar 1, 2022
@pearu @facebook-github-bot
Support CSR to COO conversion in to_sparse. (#73471)
fa3dbdc 
Summary: Pull Request resolved: #73471

Test Plan: Imported from OSS

Reviewed By: albanD

Differential Revision: D34503882

Pulled By: cpuhrsch

fbshipit-source-id: 4a781647a0ae5d03827406b75b14acc7c48da0b0
@github-actions
Copy link
Contributor
github-actions bot commented Mar 1, 2022

Hey @pearu.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@pearu
Copy link
Collaborator Author
pearu commented Mar 1, 2022

Hey @pearu. You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label.

@cpuhrsch , do you know who should look into this github-actions message as it is wrong in many ways. For instance, the message suggests the label topics: ... (notice topic is in plural) while we have labels topic: ....

@rohan-varma
Copy link
Member

Unlanding due to CI breakage https://hud2.pytorch.org/pytorch/pytorch/commit/84f4e9c10a40a0ee3f94059c722baf5ceb5f181e

@facebook-github-bot
Copy link
Contributor

This pull request has been reverted by 95204c4. To re-land this change, please open another pull request, assignthe same reviewers, fix the CI failures that caused the revert and make sure that the failing CI runs on the PR by applying the proper ciflow label (e.g., ciflow/trunk).

@rohan-varma rohan-varma mentioned this pull request Mar 1, 2022
Closed
@pearu pearu mentioned this pull request Mar 2, 2022
Closed
pearu added a commit that referenced this pull request Mar 2, 2022
@pearu
Update base for Update on "Support CSR to COO conversion in to_sparse…
8895f3e 
…(2)."

Former #73471 that was reverted due to lack of `to_sparse(sparse_dim)` support.




[ghstack-poisoned]
pearu added a commit that referenced this pull request Mar 2, 2022
@pearu
Update on "Support CSR to COO conversion in to_sparse(2)."
8386156 
Former #73471 that was reverted due to lack of `to_sparse(sparse_dim)` support.




[ghstack-poisoned]
facebook-github-bot pushed a commit that referenced this pull request Mar 2, 2022
@pearu @facebook-github-bot
Support CSR to COO conversion in to_sparse(2). (#73642)
5a3cf81 
Summary:
Pull Request resolved: #73642

Former #73471 that was reverted due to lack of `to_sparse(sparse_dim)` support.

Test Plan: Imported from OSS

Reviewed By: zou3519

Differential Revision: D34580353

Pulled By: cpuhrsch

fbshipit-source-id: a8a4ea381daeb80d8365fe931af9f55a7e789ea1
pytorchmergebot pushed a commit that referenced this pull request Mar 2, 2022
@pearu @pytorchmergebot
Support CSR to COO conversion in to_sparse(2). (#73642)
4168c87 
Summary:
Pull Request resolved: #73642

Former #73471 that was reverted due to lack of `to_sparse(sparse_dim)` support.

Test Plan: Imported from OSS

Reviewed By: zou3519

Differential Revision: D34580353

Pulled By: cpuhrsch

fbshipit-source-id: a8a4ea381daeb80d8365fe931af9f55a7e789ea1
(cherry picked from commit 5a3cf81)
@facebook-github-bot
Copy link
Contributor

This pull request has been reverted by 95204c4. To re-land this change, please open another pull request, assignthe same reviewers, fix the CI failures that caused the revert and make sure that the failing CI runs on the PR by applying the proper ciflow label (e.g., ciflow/trunk).

cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 3, 2022
@pearu @cyyever
Support CSR to COO conversion in to_sparse. (#73471)
acd5d51 
Summary: Pull Request resolved: pytorch/pytorch#73471

Test Plan: Imported from OSS

Reviewed By: albanD

Differential Revision: D34503882

Pulled By: cpuhrsch

fbshipit-source-id: 4a781647a0ae5d03827406b75b14acc7c48da0b0
(cherry picked from commit fa3dbdc6a8529d19f8a055494436ca1f766807be)
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 3, 2022
@pearu @cyyever
Support CSR to COO conversion in to_sparse(2). (#73642)
003a5c1 
Summary:
Pull Request resolved: pytorch/pytorch#73642

Former pytorch/pytorch#73471 that was reverted due to lack of `to_sparse(sparse_dim)` support.

Test Plan: Imported from OSS

Reviewed By: zou3519

Differential Revision: D34580353

Pulled By: cpuhrsch

fbshipit-source-id: a8a4ea381daeb80d8365fe931af9f55a7e789ea1
(cherry picked from commit 5a3cf8110980e5a10dbb687e87e67d5524ebf2f5)
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 3, 2022
@pearu @cyyever
Support CSR to COO conversion in to_sparse. (#73471)
3be34d5 
Summary: Pull Request resolved: pytorch/pytorch#73471

Test Plan: Imported from OSS

Reviewed By: albanD

Differential Revision: D34503882

Pulled By: cpuhrsch

fbshipit-source-id: 4a781647a0ae5d03827406b75b14acc7c48da0b0
(cherry picked from commit fa3dbdc6a8529d19f8a055494436ca1f766807be)
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 3, 2022
@pearu @cyyever
Support CSR to COO conversion in to_sparse(2). (#73642)
ea09860 
Summary:
Pull Request resolved: pytorch/pytorch#73642

Former pytorch/pytorch#73471 that was reverted due to lack of `to_sparse(sparse_dim)` support.

Test Plan: Imported from OSS

Reviewed By: zou3519

Differential Revision: D34580353

Pulled By: cpuhrsch

fbshipit-source-id: a8a4ea381daeb80d8365fe931af9f55a7e789ea1
(cherry picked from commit 5a3cf8110980e5a10dbb687e87e67d5524ebf2f5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpuhrsch cpuhrsch cpuhrsch approved these changes

@ezyang ezyang Awaiting requested review from ezyang

Assignees

@pearu pearu

Labels
cla signed module: sparse Related to torch.sparse open source release notes: sparse release notes category Reverted topic: new features topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pearu @facebook-github-bot @cpuhrsch @rohan-varma
0