[torch::deploy] remove asserts from deploy #73456
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
|
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 3d2f8b7 (more details on the Dr. CI page):
🕵️ 2 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
[ghstack-poisoned]
|
@PaliC has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
d4l3k
approved these changes
Mar 2, 2022
Replaces `at::Error` with a more simple implementation of exceptions in order to reduce the dependency of torch::deploy on torch. Note: Internal Testing / changes are still needed Differential Revision: [D34568590](https://our.internmc.facebook.com/intern/diff/D34568590) [ghstack-poisoned]
Replaces `at::Error` with a more simple implementation of exceptions in order to reduce the dependency of torch::deploy on torch. Note: Internal Testing / changes are still needed Differential Revision: [D34568590](https://our.internmc.facebook.com/intern/diff/D34568590) [ghstack-poisoned]
Replaces `at::Error` with a more simple implementation of exceptions in order to reduce the dependency of torch::deploy on torch. Note: Internal Testing / changes are still needed Differential Revision: [D34568590](https://our.internmc.facebook.com/intern/diff/D34568590) [ghstack-poisoned]
Replaces `at::Error` with a more simple implementation of exceptions in order to reduce the dependency of torch::deploy on torch. Note: Internal Testing / changes are still needed Differential Revision: [D34568590](https://our.internmc.facebook.com/intern/diff/D34568590) [ghstack-poisoned]
|
@PaliC has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Replaces `at::Error` with a more simple implementation of exceptions in order to reduce the dependency of torch::deploy on torch. Note: Internal Testing / changes are still needed Differential Revision: [D34568590](https://our.internmc.facebook.com/intern/diff/D34568590) [ghstack-poisoned]
|
@PaliC has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Replaces `at::Error` with a more simple implementation of exceptions in order to reduce the dependency of torch::deploy on torch. Note: Internal Testing / changes are still needed Differential Revision: [D34568590](https://our.internmc.facebook.com/intern/diff/D34568590) [ghstack-poisoned]
|
@PaliC has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Replaces `at::Error` with a more simple implementation of exceptions in order to reduce the dependency of torch::deploy on torch. Note: Internal Testing / changes are still needed Differential Revision: [D34568590](https://our.internmc.facebook.com/intern/diff/D34568590) [ghstack-poisoned]
|
@PaliC has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@PaliC has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Replaces `at::Error` with a more simple implementation of exceptions in order to reduce the dependency of torch::deploy on torch. Note: Internal Testing / changes are still needed Differential Revision: [D34868005](https://our.internmc.facebook.com/intern/diff/D34868005) [ghstack-poisoned]
|
@PaliC has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Replaces `at::Error` with a more simple implementation of exceptions in order to reduce the dependency of torch::deploy on torch. Note: Internal Testing / changes are still needed Differential Revision: [D34868005](https://our.internmc.facebook.com/intern/diff/D34868005) [ghstack-poisoned]
|
@PaliC has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Replaces `at::Error` with a more simple implementation of exceptions in order to reduce the dependency of torch::deploy on torch. Note: Internal Testing / changes are still needed Differential Revision: [D34868005](https://our.internmc.facebook.com/intern/diff/D34868005) [ghstack-poisoned]
|
@PaliC has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
1 similar comment
|
@PaliC has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 15, 2022
Summary: Pull Request resolved: #73456 Replaces `at::Error` with a more simple implementation of exceptions in order to reduce the dependency of torch::deploy on torch. Note: Internal Testing / changes are still needed Test Plan: Imported from OSS Reviewed By: samdow Differential Revision: D34868005 Pulled By: PaliC fbshipit-source-id: c8bb1f7a2b169b5a8e3b63a697e0ced748a0524c
|
Hey @PaliC. |
|
This pull request has been reverted by cc5f8ae. To re-land this change, please open another pull request, assignthe same reviewers, fix the CI failures that caused the revert and make sure that the failing CI runs on the PR by applying the proper ciflow label (e.g., ciflow/trunk). |
PaliC
added a commit
to PaliC/pytorch
that referenced
this pull request
Mar 16, 2022
Summary: Pull Request resolved: pytorch#74283 Remove `c10::errors` from torch::deploy and replace them with `multipy::errors` which is effectively a wrapper around `std::runtime_error. Review History can be found with pytorch#73456 Test Plan: buck test //caffe2/torch/csrc/deploy:test_deploy Differential Revision: D34905174 fbshipit-source-id: 528d9b3a010360645c669efa3c7852d7ae5e649c
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 16, 2022
Summary: Pull Request resolved: #74283 Remove `c10::errors` from torch::deploy and replace them with `multipy::errors` which is effectively a wrapper around `std::runtime_error. Review History can be found with #73456 Test Plan: buck test //caffe2/torch/csrc/deploy:test_deploy Reviewed By: aivanou Differential Revision: D34905174 fbshipit-source-id: 8883fc77dce66c489fa3fa9d14a71d1de1e0cc5f
pytorchmergebot
pushed a commit
that referenced
this pull request
Mar 16, 2022
Summary: Pull Request resolved: #74283 Remove `c10::errors` from torch::deploy and replace them with `multipy::errors` which is effectively a wrapper around `std::runtime_error. Review History can be found with #73456 Test Plan: buck test //caffe2/torch/csrc/deploy:test_deploy Reviewed By: aivanou Differential Revision: D34905174 fbshipit-source-id: 8883fc77dce66c489fa3fa9d14a71d1de1e0cc5f (cherry picked from commit 7fffcdf)
|
This pull request has been reverted by cc5f8ae. To re-land this change, please open another pull request, assignthe same reviewers, fix the CI failures that caused the revert and make sure that the failing CI runs on the PR by applying the proper ciflow label (e.g., ciflow/trunk). |
NesrineMHB
pushed a commit
to NesrineMHB/pytorch
that referenced
this pull request
Apr 7, 2022
ghstack-source-id: efceb02 Pull Request resolved: pytorch/pytorch#73456
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Replaces
at::Errorwith a more simple implementation of exceptions in order to reduce the dependency of torch::deploy on torch.Note: Internal Testing / changes are still needed
Differential Revision: D34868005