remove some spurious warnings fixing #72352
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI Flow Status⚛️ CI FlowRuleset - Version:
|
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit e4aa5f0 (more details on the Dr. CI page):
🕵️ 15 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
ngimel
approved these changes
Feb 4, 2022
9ad2d3c to
157aed2
Compare
|
@albanD has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
soulitzer
reviewed
Feb 4, 2022
| const auto& grad_strides = grad.strides(); | ||
| const auto& variable_strides = variable.strides(); | ||
| for (const auto idx : c10::irange(grad_sizes.size())) { | ||
| if (grad_sizes[idx] != 1) { |
There was a problem hiding this comment.
Should we also skip the check if size=0?
There was a problem hiding this comment.
Size 0 means empty Tensor. Which is a lot trickier to think about. And a lot more rare when Parameters. So I though we could ignore this case for now.
157aed2 to
e4aa5f0
Compare
|
@albanD has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 7, 2022
|
Hey @albanD. |
|
This pull request has been reverted by 5654b68. To re-land this change, follow these steps. |
|
This pull request has been reverted by 5654b68. To re-land this change, please open another pull request, assignthe same reviewers, fix the CI failures that caused the revert and make sure that the failing CI runs on the PR by applying the proper ciflow label (e.g., ciflow/trunk). |
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 9, 2022
Summary: Fixes pytorch/pytorch#70389 Pull Request resolved: pytorch/pytorch#72352 Reviewed By: jbschlosser Differential Revision: D34011981 Pulled By: albanD fbshipit-source-id: 55bedc8a40929bc5b49cb6d7d7d51a3750f2ff27 (cherry picked from commit a6657a9071a48e8f3a8b35a75a06c669ab82d56b)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 9, 2022
Summary: Fixes pytorch/pytorch#70389 Pull Request resolved: pytorch/pytorch#72352 Reviewed By: jbschlosser Differential Revision: D34011981 Pulled By: albanD fbshipit-source-id: 55bedc8a40929bc5b49cb6d7d7d51a3750f2ff27 (cherry picked from commit a6657a9071a48e8f3a8b35a75a06c669ab82d56b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #70389