8000 [ROCm] Enable sort operator BF16 support by pruthvistony · Pull Request #71226 · pytorch/pytorch · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[ROCm] Enable sort operator BF16 support #71226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

[ROCm] Enable sort operator BF16 support #71226

wants to merge 7 commits into from

Conversation

pruthvistony
Copy link
Collaborator
@pruthvistony pruthvistony commented Jan 12, 2022 •
edited by pytorch-probot bot
Loading

@pytorch-probot pytorch-probot bot added module: rocm AMD GPU support for Pytorch ciflow/default labels Jan 12, 2022
@pytorch-probot
Copy link
pytorch-probot bot commented Jan 12, 2022 •
edited by pytorch-bot bot
Loading
CI Flow Status

⚛️ CI Flow

Ruleset - Version: v1
Ruleset - File: https://github.com/ROCmSoftwarePlatform/pytorch/blob/5704945b950a51612c4e326b68997dff7db7c123/.github/generated-ciflow-ruleset.json
PR ciflow labels: ciflow/default

Workflows Labels (bold enabled) Status
Triggered Workflows
linux-bionic-py3.7-clang9 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/noarch, ciflow/trunk ✅ triggered
linux-docs ciflow/all, ciflow/cpu, ciflow/default, ciflow/docs, ciflow/linux, ciflow/trunk ✅ triggered
linux-vulkan-bionic-py3.7-clang9 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk, ciflow/vulkan ✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7-bazel-test ciflow/all, ciflow/bazel, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
linux-xenial-py3-clang5-mobile-build ciflow/all, ciflow/default, ciflow/linux, ciflow/mobile, ciflow/trunk ✅ triggered
linux-xenial-py3-clang5-mobile-custom-build-static ciflow/all, ciflow/default, ciflow/linux, ciflow/mobile, ciflow/trunk ✅ triggered
linux-xenial-py3.7-clang7-asan ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/sanitizers, ciflow/trunk ✅ triggered
linux-xenial-py3.7-clang7-onnx ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/onnx, ciflow/trunk ✅ triggered
linux-xenial-py3.7-gcc5.4 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
linux-xenial-py3.7-gcc7 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
linux-xenial-py3.7-gcc7-no-ops ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single ciflow/all, ciflow/android, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single-full-jit ciflow/all, ciflow/android, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
win-vs2019-cpu-py3 ciflow/all, ciflow/cpu, ciflow/default, ciflow/trunk, ciflow/win ✅ triggered
win-vs2019-cuda11.3-py3 ciflow/all, ciflow/cuda, ciflow/default, ciflow/trunk, ciflo 8000 w/win ✅ triggered
Skipped Workflows
caffe2-linux-xenial-py3.7-gcc5.4 ciflow/all, ciflow/cpu, ciflow/linux, ciflow/trunk 🚫 skipped
docker-builds ciflow/all, ciflow/trunk 🚫 skipped
ios-12-5-1-arm64 ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk 🚫 skipped
ios-12-5-1-arm64-coreml ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk 🚫 skipped
ios-12-5-1-arm64-custom-ops ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk 🚫 skipped
ios-12-5-1-arm64-full-jit ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk 🚫 skipped
ios-12-5-1-arm64-metal ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk 🚫 skipped
ios-12-5-1-x86-64 ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk 🚫 skipped
ios-12-5-1-x86-64-coreml ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk 🚫 skipped
ios-12-5-1-x86-64-full-jit ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk 🚫 skipped
libtorch-linux-xenial-cuda10.2-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux, ciflow/trunk 🚫 skipped
libtorch-linux-xenial-cuda11.3-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux, ciflow/trunk 🚫 skipped
linux-bionic-cuda10.2-py3.9-gcc7 ciflow/all, ciflow/cuda, ciflow/linux, ciflow/slow, ciflow/trunk 🚫 skipped
linux-docs-push ciflow/all, ciflow/cpu, ciflow/linux, ciflow/scheduled 🚫 skipped
linux-xenial-cuda11.3-py3.7-gcc7-no-ops ciflow/all, ciflow/cuda, ciflow/linux, ciflow/trunk 🚫 skipped
macos-10-15-py3-arm64 ciflow/all, ciflow/macos, ciflow/trunk 🚫 skipped
macos-10-15-py3-lite-interpreter-x86-64 ciflow/all, ciflow/macos, ciflow/trunk 🚫 skipped
macos-11-py3-x86-64 ciflow/all, ciflow/macos, ciflow/trunk 🚫 skipped
parallelnative-linux-xenial-py3.7-gcc5.4 ciflow/all, ciflow/cpu, ciflow/linux, ciflow/trunk 🚫 skipped
periodic-libtorch-linux-bionic-cuda11.5-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux, ciflow/scheduled 🚫 skipped
periodic-libtorch-linux-xenial-cuda11.1-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux, ciflow/scheduled 🚫 skipped
periodic-linux-bionic-cuda11.5-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/linux, ciflow/scheduled 🚫 skipped
periodic-linux-xenial-cuda10.2-py3-gcc7-slow-gradcheck ciflow/all, ciflow/cuda, ciflow/linux, ciflow/scheduled, ciflow/slow, ciflow/slow-gradcheck 🚫 skipped
periodic-linux-xenial-cuda11.1-py3.7-gcc7-debug ciflow/all, ciflow/cuda, ciflow/linux, ciflow/scheduled 🚫 skipped
periodic-win-vs2019-cuda11.1-py3 ciflow/all, ciflow/cuda, ciflow/scheduled, ciflow/win 🚫 skipped
periodic-win-vs2019-cuda11.5-py3 ciflow/all, ciflow/cuda, ciflow/scheduled, ciflow/win 🚫 skipped
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-build ciflow/all, ciflow/android, ciflow/cpu, ciflow/linux, ciflow/trunk 🚫 skipped

You can add a comment to the PR and tag @pytorchbot with the following commands: 
# ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun

# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slow

For more information, please take a look at the CI Flow Wiki.

@facebook-github-bot
Copy link
Contributor
facebook-github-bot commented Jan 12, 2022 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 3f2af70 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@amathews-amd amathews-amd mentioned this pull request Jan 12, 2022
Closed
@ejguan ejguan added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jan 12, 2022
@pruthvistony pruthvistony force-pushed the sort_bf16 branch 2 times, most recently from 718c83a to aefee48 Compare January 19, 2022 12:45
@pruthvistony
Copy link
Collaborator Author

@jithunnair-amd and @jeffdaily
Can you please review this PR.

jeffdaily
jeffdaily reviewed Jan 19, 2022
View reviewed changes
@jeffdaily
Copy link
Collaborator

Can confirm newly enabled CI tests are now passing.

From https://ci.pytorch.org/jenkins/job/pytorch-builds/job/pytorch-linux-bionic-rocm4.5-py3.7-test2/2114/consoleFull

14:03:26   test_stable_sort_against_numpy_cuda_bfloat16 (__main__.TestSortAndSelectCUDA) ... ok (0.008s)
...
14:03:26   test_stable_sort_cuda_bfloat16 (__main__.TestSortAndSelectCUDA) ... ok (0.005s)

jeffdaily
jeffdaily approved these changes Jan 19, 2022
View reviewed changes
Copy link
Collaborator
@jeffdaily jeffdaily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pruthvistony
Copy link
Collaborator Author

Can confirm newly enabled CI tests are now passing.

From https://ci.pytorch.org/jenkins/job/pytorch-builds/job/pytorch-linux-bionic-rocm4.5-py3.7-test2/2114/consoleFull

14:03:26   test_stable_sort_against_numpy_cuda_bfloat16 (__main__.TestSortAndSelectCUDA) ... ok (0.008s)
...
14:03:26   test_stable_sort_cuda_bfloat16 (__main__.TestSortAndSelectCUDA) ... ok (0.005s)

Yes, verified the logs
14:03:26 test_stable_sort_cuda_bfloat16 (main.TestSortAndSelectCUDA) ... ok (0.005s)
14:03:26 test_msort_cuda_bfloat16 (main.TestSortAndSelectCUDA) ... ok (0.007s)

Also I have tested these testcases locally by enabling logs.

jithunnair-amd
jithunnair-amd requested changes Jan 20, 2022
View reviewed changes
Copy link
Collaborator
@jithunnair-amd jithunnair-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just request to put a comment back.

@pruthvistony pruthvistony mentioned this pull request Jan 28, 2022
Closed
@jithunnair-amd
Copy link
Collaborator
jithunnair-amd commented Jan 28, 2022 •
edited
Loading

cc @ngimel @malfet to review

cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Feb 15, 2022
@pruthvistony @cyyever
[ROCm] Enable sort operator BF16 support (#71226)
bc4bf1d 
Summary:
Related to [https://github.com/pytorch/pytorch/issues/58196](https://github.com/pytorch/pytorch/pull/58196)

cc jeffdaily sunway513 jithunnair-amd ROCmSupport KyleCZH amathews-amd

Pull Request resolved: pytorch/pytorch#71226

Reviewed By: malfet

Differential Revision: D34152115

Pulled By: seemethere

fbshipit-source-id: 53841c91976bdb5a0002362f22a54ec23aa2f78f
(cherry picked from commit 963027c7f28cf20e1c4e5722eb62b5629e735a8e)
@malfet
Copy link
Contributor
malfet commented Feb 15, 2022 •
edited
Loading

Reverting, as it clearly broke CI, see https://hud.pytorch.org/ci/pytorch/pytorch/master?name_filter=rocm and https://hud.pytorch.org/commit/pytorch/pytorch/aa44480b40075d4f696605f3ab7a03d87372b4e2

@facebook-github-bot
Copy link
Contributor

This pull request has been reverted by 80f2346. To re-land this change, please open another pull request, assignthe same reviewers, fix the CI failures that caused the revert and make sure that the failing CI runs on the PR by applying the proper ciflow label (e.g., ciflow/trunk).

@pruthvistony
Copy link
Collaborator Author
pruthvistony commented Feb 15, 2022 •
edited
Loading

@malfet
PR - #72837
fixes the break. Can you please help on merging it.

or better I will raise a new PR merging both.

Thank you.

@malfet
Copy link
Contributor
malfet commented Feb 15, 2022

@pruthvistony please do, as this PR has already been reverted. And if you are aware of the regression, please leave the comment here so that people are aware of the ongoing work

@jithunnair-amd jithunnair-amd mentioned this pull request Feb 15, 2022
Closed
@pruthvistony pruthvistony mentioned this pull request Feb 15, 2022
Closed
@pruthvistony
Copy link
Collaborator Author

The new PR with fix is raised - #72854

cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Feb 15, 2022
@pruthvistony @cyyever
[ROCm] Enable sort operator BF16 support (#71226)
142b23a 
Summary:
Related to [https://github.com/pytorch/pytorch/issues/58196](https://github.com/pytorch/pytorch/pull/58196)

cc jeffdaily sunway513 jithunnair-amd ROCmSupport KyleCZH amathews-amd

Pull Request resolved: pytorch/pytorch#71226

Reviewed By: malfet

Differential Revision: D34152115

Pulled By: seemethere

fbshipit-source-id: 53841c91976bdb5a0002362f22a54ec23aa2f78f
(cherry picked from commit 963027c7f28cf20e1c4e5722eb62b5629e735a8e)
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Feb 16, 2022
@pruthvistony @cyyever
[ROCm] Enable sort operator BF16 support (#71226)
63c7c2c 
Summary:
Related to [https://github.com/pytorch/pytorch/issues/58196](https://github.com/pytorch/pytorch/pull/58196)

cc jeffdaily sunway513 jithunnair-amd ROCmSupport KyleCZH amathews-amd

Pull Request resolved: pytorch/pytorch#71226

Reviewed By: malfet

Differential Revision: D34152115

Pulled By: seemethere

fbshipit-source-id: 53841c91976bdb5a0002362f22a54ec23aa2f78f
(cherry picked from commit 963027c7f28cf20e1c4e5722eb62b5629e735a8e)
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Feb 16, 2022
@pruthvistony @cyyever
[ROCm] Enable sort operator BF16 support (#71226)
f5e39c0 
Summary:
Related to [https://github.com/pytorch/pytorch/issues/58196](https://github.com/pytorch/pytorch/pull/58196)

cc jeffdaily sunway513 jithunnair-amd ROCmSupport KyleCZH amathews-amd

Pull Request resolved: pytorch/pytorch#71226

Reviewed By: malfet

Differential Revision: D34152115

Pulled By: seemethere

fbshipit-source-id: 53841c91976bdb5a0002362f22a54ec23aa2f78f
(cherry picked from commit 963027c7f28cf20e1c4e5722eb62b5629e735a8e)
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Feb 17, 2022
@pruthvistony @cyyever
[ROCm] Enable sort operator BF16 support (#71226)
cdfbcd9 
Summary:
Related to [https://github.com/pytorch/pytorch/issues/58196](https://github.com/pytorch/pytorch/pull/58196)

cc jeffdaily sunway513 jithunnair-amd ROCmSupport KyleCZH amathews-amd

Pull Request resolved: pytorch/pytorch#71226

Reviewed By: malfet

Differential Revision: D34152115

Pulled By: seemethere

fbshipit-source-id: 53841c91976bdb5a0002362f22a54ec23aa2f78f
(cherry picked from commit 963027c7f28cf20e1c4e5722eb62b5629e735a8e)
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Feb 17, 2022
@pruthvistony @cyyever
[ROCm] Enable sort operator BF16 support (#71226)
5058825 
Summary:
Related to [https://github.com/pytorch/pytorch/issues/58196](https://github.com/pytorch/pytorch/pull/58196)

cc jeffdaily sunway513 jithunnair-amd ROCmSupport KyleCZH amathews-amd

Pull Request resolved: pytorch/pytorch#71226

Reviewed By: malfet

Differential Revision: D34152115

Pulled By: seemethere

fbshipit-source-id: 53841c91976bdb5a0002362f22a54ec23aa2f78f
(cherry picked from commit 963027c7f28cf20e1c4e5722eb62b5629e735a8e)
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Feb 17, 2022
@pruthvistony @cyyever
[ROCm] Enable sort operator BF16 support (#71226)
8a8c1ae 
Summary:
Related to [https://github.com/pytorch/pytorch/issues/58196](https://github.com/pytorch/pytorch/pull/58196)

cc jeffdaily sunway513 jithunnair-amd ROCmSupport KyleCZH amathews-amd

Pull Request resolved: pytorch/pytorch#71226

Reviewed By: malfet

Differential Revision: D34152115

Pulled By: seemethere

fbshipit-source-id: 53841c91976bdb5a0002362f22a54ec23aa2f78f
(cherry picked from commit 963027c7f28cf20e1c4e5722eb62b5629e735a8e)
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Feb 17, 2022
@pruthvistony @cyyever
[ROCm] Enable sort operator BF16 support (#71226)
3b77573 
Summary:
Related to [https://github.com/pytorch/pytorch/issues/58196](https://github.com/pytorch/pytorch/pull/58196)

cc jeffdaily sunway513 jithunnair-amd ROCmSupport KyleCZH amathews-amd

Pull Request resolved: pytorch/pytorch#71226

Reviewed By: malfet

Differential Revision: D34152115

Pulled By: seemethere

fbshipit-source-id: 53841c91976bdb5a0002362f22a54ec23aa2f78f
(cherry picked from commit 963027c7f28cf20e1c4e5722eb62b5629e735a8e)
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Feb 17, 2022
@pruthvistony @cyyever
[ROCm] Enable sort operator BF16 support (#71226)
4970a03 
Summary:
Related to [https://github.com/pytorch/pytorch/issues/58196](https://github.com/pytorch/pytorch/pull/58196)

cc jeffdaily sunway513 jithunnair-amd ROCmSupport KyleCZH amathews-amd

Pull Request resolved: pytorch/pytorch#71226

Reviewed By: malfet

Differential Revision: D34152115

Pulled By: seemethere

fbshipit-source-id: 53841c91976bdb5a0002362f22a54ec23aa2f78f
(cherry picked from commit 963027c7f28cf20e1c4e5722eb62b5629e735a8e)
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Feb 17, 2022
@pruthvistony @cyyever
[ROCm] Enable sort operator BF16 support (#71226)
14f4b02 
Summary:
Related to [https://github.com/pytorch/pytorch/issues/58196](https://github.com/pytorch/pytorch/pull/58196)

cc jeffdaily sunway513 jithunnair-amd ROCmSupport KyleCZH amathews-amd

Pull Request resolved: pytorch/pytorch#71226

Reviewed By: malfet

Differential Revision: D34152115

Pulled By: seemethere

fbshipit-source-id: 53841c91976bdb5a0002362f22a54ec23aa2f78f
(cherry picked from commit 963027c7f28cf20e1c4e5722eb62b5629e735a8e)
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Feb 17, 2022
@pruthvistony @cyyever
[ROCm] Enable sort operator BF16 support (#71226)
d075a47 
Summary:
Related to [https://github.com/pytorch/pytorch/issues/58196](https://github.com/pytorch/pytorch/pull/58196)

cc jeffdaily sunway513 jithunnair-amd ROCmSupport KyleCZH amathews-amd

Pull Request resolved: pytorch/pytorch#71226

Reviewed By: malfet

Differential Revision: D34152115

Pulled By: seemethere

fbshipit-source-id: 53841c91976bdb5a0002362f22a54ec23aa2f78f
(cherry picked from commit 963027c7f28cf20e1c4e5722eb62b5629e735a8e)
@janeyx99 janeyx99 mentioned this pull request Feb 18, 2022
Closed
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Feb 20, 2022
@pruthvistony @cyyever
[ROCm] Enable sort operator BF16 support (#71226)
bf957ba 
Summary:
Related to [https://github.com/pytorch/pytorch/issues/58196](https://github.com/pytorch/pytorch/pull/58196)

cc jeffdaily sunway513 jithunnair-amd ROCmSupport KyleCZH amathews-amd

Pull Request resolved: pytorch/pytorch#71226

Reviewed By: malfet

Differential Revision: D34152115

Pulled By: seemethere

fbshipit-source-id: 53841c91976bdb5a0002362f22a54ec23aa2f78f
(cherry picked from commit 963027c7f28cf20e1c4e5722eb62b5629e735a8e)
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Feb 20, 2022
@pruthvistony @cyyever
[ROCm] Enable sort operator BF16 support (#71226)
716b115 
Summary:
Related to [https://github.com/pytorch/pytorch/issues/58196](https://github.com/pytorch/pytorch/pull/58196)

cc jeffdaily sunway513 jithunnair-amd ROCmSupport KyleCZH amathews-amd

Pull Request resolved: pytorch/pytorch#71226

Reviewed By: malfet

Differential Revision: D34152115

Pulled By: seemethere

fbshipit-source-id: 53841c91976bdb5a0002362f22a54ec23aa2f78f
(cherry picked from commit 963027c7f28cf20e1c4e5722eb62b5629e735a8e)
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Feb 20, 2022
@pruthvistony @cyyever
[ROCm] Enable sort operator BF16 support (#71226)
a758174 
Summary:
Related to [https://github.com/pytorch/pytorch/issues/58196](https://github.com/pytorch/pytorch/pull/58196)

cc jeffdaily sunway513 jithunnair-amd ROCmSupport KyleCZH amathews-amd

Pull Request resolved: pytorch/pytorch#71226

Reviewed By: malfet

Differential Revision: D34152115

Pulled By: seemethere

fbshipit-source-id: 53841c91976bdb5a0002362f22a54ec23aa2f78f
(cherry picked from commit 963027c7f28cf20e1c4e5722eb62b5629e735a8e)
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Feb 21, 2022
@pruthvistony @cyyever
[ROCm] Enable sort operator BF16 support (#71226)
d5cba8f 
Summary:
Related to [https://github.com/pytorch/pytorch/issues/58196](https://github.com/pytorch/pytorch/pull/58196)

cc jeffdaily sunway513 jithunnair-amd ROCmSupport KyleCZH amathews-amd

Pull Request resolved: pytorch/pytorch#71226

Reviewed By: malfet

Differential Revision: D34152115

Pulled By: seemethere

fbshipit-source-id: 53841c91976bdb5a0002362f22a54ec23aa2f78f
(cherry picked from commit 963027c7f28cf20e1c4e5722eb62b5629e735a8e)
@facebook-github-bot
Copy link
Contributor

This pull request has been reverted by 80f2346. To re-land this change, please open another pull request, assignthe same reviewers, fix the CI failures that caused the revert and make sure that the failing CI runs on the PR by applying the proper ciflow label (e.g., ciflow/trunk).

facebook-github-bot pushed a commit that referenced this pull request Feb 23, 2022
@pruthvistony @facebook-github-bot
[ROCm] Enable sort operator BF16 support (#72854)
e9e7e3e 
Summary:
The changes add support for dtype BF16 for sort operator in ROCm.

Relates - #58196

Relanding the change - #71226

jeffdaily jithunnair-amd dllehr-amd Please review this PR.

Pull Request resolved: #72854

Reviewed By: zou3519

Differential Revision: D34284313

Pulled By: malfet

fbshipit-source-id: abcfea84ea53874008d56416425849e990ebf15b
pytorchmergebot pushed a commit that referenced this pull request Feb 23, 2022
@pruthvistony @pytorchmergebot
[ROCm] Enable sort operator BF16 support (#72854)
595a51b 
Summary:
The changes add support for dtype BF16 for sort operator in ROCm.

Relates - #58196

Relanding the change - #71226

jeffdaily jithunnair-amd dllehr-amd Please review this PR.

Pull Request resolved: #72854

Reviewed By: zou3519

Differential Revision: D34284313

Pulled By: malfet

fbshipit-source-id: abcfea84ea53874008d56416425849e990ebf15b
(cherry picked from commit e9e7e3e)
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 3, 2022
@pruthvistony @cyyever
[ROCm] Enable sort operator BF16 support (#72854)
c2e1888 
Summary:
The changes add support for dtype BF16 for sort operator in ROCm.

Relates - pytorch/pytorch#58196

Relanding the change - pytorch/pytorch#71226

jeffdaily jithunnair-amd dllehr-amd Please review this PR.

Pull Request resolved: pytorch/pytorch#72854

Reviewed By: zou3519

Differential Revision: D34284313

Pulled By: malfet

fbshipit-source-id: abcfea84ea53874008d56416425849e990ebf15b
(cherry picked from commit e9e7e3e0472b726ff2fd5f115962d3c835fb33db)
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 3, 2022
@pruthvistony @cyyever
[ROCm] Enable sort operator BF16 support (#72854)
8f999cd 
Summary:
The changes add support for dtype BF16 for sort operator in ROCm.

Relates - pytorch/pytorch#58196

Relanding the change - pytorch/pytorch#71226

jeffdaily jithunnair-amd dllehr-amd Please review this PR.

Pull Request resolved: pytorch/pytorch#72854

Reviewed By: zou3519

Differential Revision: D34284313

Pulled By: malfet

fbshipit-source-id: abcfea84ea53874008d56416425849e990ebf15b
(cherry picked from commit e9e7e3e0472b726ff2fd5f115962d3c835fb33db)
@pruthvistony pruthvistony deleted the sort_bf16 branch April 2, 2022 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffdaily jeffdaily jeffdaily approved these changes

@seemethere seemethere seemethere approved these changes

@jithunnair-amd jithunnair-amd jithunnair-amd approved these changes

Assignees
No one assigned
Labels
cla signed module: rocm AMD GPU support for Pytorch open source Reverted triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@pruthvistony @facebook-github-bot @jeffdaily @jithunnair-amd @seemethere @malfet @pytorchbot @ejguan @amathews-amd
0