8000 [jit] Split Tensor type implementations to separate file. by zhxchen17 · Pull Request #70121 · pytorch/pytorch · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[jit] Split Tensor type implementations to separate file. #70121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 17 commits into from
Closed

[jit] Split Tensor type implementations to separate file. #70121

wants to merge 17 commits into from

Conversation

zhxchen17
Copy link
Contributor
@zhxchen17 zhxchen17 commented Dec 17, 2021 •
edited
Loading

Stack from ghstack:

Code move all TensorType dependencies into a separate tensor_type.cpp, so that we don't link with it in the min runtime accidentally.

Differential Revision: D33102286

NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!

@zhxchen17
[jit] Split Tensor type implementations to separate file.
04b5b85 
Code move all TensorType dependencies into a separate `tensor_type.cpp`, so that we don't link with it in the min runtime accidentally.

Differential Revision: [D33102286](https://our.internmc.facebook.com/intern/diff/D33102286/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D33102286/)!

[ghstack-poisoned]
@pytorch-probot
Copy link
pytorch-probot bot commented Dec 17, 2021 •
edited
Loading
CI Flow Status

⚛️ CI Flow

Ruleset - Version: v1
Ruleset - File: https://github.com/pytorch/pytorch/blob/d3d1e2fa6641e2a6ac959aed6d03f078c80febed/.github/generated-ciflow-ruleset.json
PR ciflow labels: ciflow/default

Workflows Labels (bold enabled) Status
Triggered Workflows
linux-bionic-py3.7-clang9 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/noarch, ciflow/trunk ✅ triggered
linux-docs ciflow/all, ciflow/cpu, ciflow/default, ciflow/docs, ciflow/linux, ciflow/trunk ✅ triggered
linux-vulkan-bionic-py3.7-clang9 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk, ciflow/vulkan ✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7-bazel-test ciflow/all, ciflow/bazel, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
linux-xenial-py3-clang5-mobile-build ciflow/all, ciflow/default, ciflow/linux, ciflow/mobile, ciflow/trunk ✅ triggered
linux-xenial-py3-clang5-mobile-custom-build-static ciflow/all, ciflow/default, ciflow/linux, ciflow/mobile, ciflow/trunk ✅ triggered
linux-xenial-py3.7-clang7-asan ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/sanitizers, ciflow/trunk ✅ triggered
linux-xenial-py3.7-clang7-onnx ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/onnx, ciflow/trunk ✅ triggered
linux-xenial-py3.7-gcc5.4 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
linux-xenial-py3.7-gcc7 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
linux-xenial-py3.7-gcc7-no-ops ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single ciflow/all, ciflow/android, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single-full-jit ciflow/all, ciflow/android, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
win-vs2019-cpu-py3 ciflow/all, ciflow/cpu, ciflow/default, ciflow/trunk, ciflow/win ✅ triggered
win-vs2019-cuda11.3-py3 ciflow/all, ciflow/cuda, ciflow/default, ciflow/trunk, ciflow/win ✅ triggered
Skipped Workflows
caffe2-linux-xenial-py3.7-gcc5.4 ciflow/all, ciflow/cpu, ciflow/linux, ciflow/trunk 🚫 skipped
docker-builds ciflow/all, ciflow/trunk 🚫 skipped
ios-12-5-1-arm64 ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk 🚫 skipped
ios-12-5-1-arm64-coreml ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk 🚫 skipped
ios-12-5-1-arm64-custom-ops ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk 🚫 skipped
ios-12-5-1-arm64-full-jit ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk 🚫 skipped
ios-12-5-1-arm64-metal ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk 🚫 skipped
ios-12-5-1-x86-64 ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk 🚫 skipped
ios-12-5-1-x86-64-coreml ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk 🚫 skipped
ios-12-5-1-x86-64-full-jit ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk 🚫 skipped
libtorch-linux-xenial-cuda10.2-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux, ciflow/trunk 🚫 skipped
libtorch-linux-xenial-cuda11.3-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux, ciflow/trunk 🚫 skipped
linux-bionic-cuda10.2-py3.9-gcc7 ciflow/all, ciflow/cuda, ciflow/linux, ciflow/slow, ciflow/trunk 🚫 skipped
linux-docs-push ciflow/all, ciflow/cpu, ciflow/linux, ciflow/scheduled 🚫 skipped
linux-xenial-cuda11.3-py3.7-gcc7-no-ops ciflow/all, ciflow/cuda, ciflow/linux, ciflow/trunk 🚫 skipped
macos-10-15-py3-arm64 ciflow/all, ciflow/macos, ciflow/trunk 🚫 skipped
macos-10-15-py3-lite-interpreter-x86-64 ciflow/all, ciflow/macos, ciflow/trunk 🚫 skipped
macos-11-py3-x86-64 ciflow/all, ciflow/macos, ciflow/trunk 🚫 skipped
parallelnative-linux-xenial-py3.7-gcc5.4 ciflow/all, ciflow/cpu, ciflow/linux, ciflow/trunk 🚫 skipped
periodic-libtorch-linux-bionic-cuda11.5-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux, ciflow/scheduled 🚫 skipped
periodic-libtorch-linux-xenial-cuda11.1-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux, ciflow/scheduled 🚫 skipped
periodic-linux-bionic-cuda11.5-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/linux, ciflow/scheduled 🚫 skipped
periodic-linux-xenial-cuda10.2-py3-gcc7-slow-gradcheck ciflow/all, ciflow/cuda, ciflow/linux, ciflow/scheduled, ciflow/slow, ciflow/slow-gradcheck 🚫 skipped
periodic-linux-xenial-cuda11.1-py3.7-gcc7-debug ciflow/all, ciflow/cuda, ciflow/linux, ciflow/scheduled 🚫 skipped
periodic-win-vs2019-cuda11.1-py3 ciflow/all, ciflow/cuda, ciflow/scheduled, ciflow/win 🚫 skipped
periodic-win-vs2019-cuda11.5-py3 ciflow/all, ciflow/cuda, ciflow/scheduled, ciflow/win 🚫 skipped
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-build ciflow/all, ciflow/android, ciflow/cpu, ciflow/linux, ciflow/trunk 🚫 skipped

You can add a comment to the PR and tag @pytorchbot with the following commands: 
# ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun

# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slow

For more information, please take a look at the CI Flow Wiki.

@facebook-github-bot
Copy link
Contributor
facebook-github-bot commented Dec 17, 2021 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit d3d1e2f (more details on the Dr. CI page):

✅ None of the CI failures appear to be your fault 💚

🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD
This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

This was referenced Dec 17, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
zhxchen17 added a commit that referenced this pull request Dec 17, 2021
@zhxchen17
[jit] Split Tensor type implementations to separate file.
f72e5b4 
Code move all TensorType dependencies into a separate `tensor_type.cpp`, so that we don't link with it in the min runtime accidentally.

Differential Revision: [D33102286](https://our.internmc.facebook.com/intern/diff/D33102286/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D33102286/)!

ghstack-source-id: 145937392
Pull Request resolved: #70121
@zhxchen17
Update on "[jit] Split Tensor type implementations to separate file."
6043df5 
Code move all TensorType dependencies into a separate `tensor_type.cpp`, so that we don't link with it in the min runtime accidentally.

Differential Revision: [D33102286](https://our.internmc.facebook.com/intern/diff/D33102286/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D33102286/)!

[ghstack-poisoned]
zhxchen17 added a commit that referenced this pull request Dec 20, 2021
@zhxchen17
[jit] Split Tensor type implementations to separate file.
277822d 
Pull Request resolved: #70121

Code move all TensorType dependencies into a separate `tensor_type.cpp`, so that we don't link with it in the min runtime accidentally.
ghstack-source-id: 146014848

Differential Revision: [D33102286](https://our.internmc.facebook.com/intern/diff/D33102286/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D33102286/)!
@zhxchen17
Update on "[jit] Split Tensor type implementations to separate file."
a6ec0f7 
Code move all TensorType dependencies into a separate `tensor_type.cpp`, so that we don't link with it in the min runtime accidentally.

Differential Revision: [D33102286](https://our.internmc.facebook.com/intern/diff/D33102286/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D33102286/)!

[ghstack-poisoned]
This was referenced Dec 20, 2021
Closed
Closed
@zhxchen17
Update on "[jit] Split Tensor type implementations to separate file."
430ee1e 
Code move all TensorType dependencies into a separate `tensor_type.cpp`, so that we don't link with it in the min runtime accidentally.

Differential Revision: [D33102286](https://our.internmc.facebook.com/intern/diff/D33102286/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D33102286/)!

[ghstack-poisoned]
@zhxchen17 zhxchen17 mentioned this pull request Dec 20, 2021
Closed
@zhxchen17
Update on "[jit] Split Tensor type implementations to separate file."
9704960 
Code move all TensorType dependencies into a separate `tensor_type.cpp`, so that we don't link with it in the min runtime accidentally.

Differential Revision: [D33102286](https://our.internmc.facebook.com/intern/diff/D33102286/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D33102286/)!

[ghstack-poisoned]
@zhxchen17
Update on "[jit] Split Tensor type implementations to separate file."
242bf72 
Code move all TensorType dependencies into a separate `tensor_type.cpp`, so that we don't link with it in the min runtime accidentally.

Differential Revision: [D33102286](https://our.internmc.facebook.com/intern/diff/D33102286/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D33102286/)!

[ghstack-poisoned]
@zhxchen17
Update on "[jit] Split Tensor type implementations to separate file."
da1f194 
Code move all TensorType dependencies into a separate `tensor_type.cpp`, so that we don't link with it in the min runtime accidentally.

Differential Revision: [D33102286](https://our.internmc.facebook.com/intern/diff/D33102286/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D33102286/)!

[ghstack-poisoned]
@zhxchen17 zhxchen17 mentioned this pull request Dec 21, 2021
Closed
@zhxchen17
Update on "[jit] Split Tensor type implementations to separate file."
6777ca4 
Code move all TensorType dependencies into a separate `tensor_type.cpp`, so that we don't link with it in the min runtime accidentally.

Differential Revision: [D33102286](https://our.internmc.facebook.com/intern/diff/D33102286/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D33102286/)!

[ghstack-poisoned]
@zhxchen17 zhxchen17 mentioned this pull request Dec 21, 2021
Closed
@zhxchen17
Update on "[jit] Split Tensor type implementations to separate file."
9fc67f4 
Code move all TensorType dependencies into a separate `tensor_type.cpp`, so that we don't link with it in the min runtime accidentally.

Differential Revision: [D33102286](https://our.internmc.facebook.com/intern/diff/D33102286/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D33102286/)!

[ghstack-poisoned]
@zhxchen17 zhxchen17 mentioned this pull request Dec 23, 2021
Closed
@zhxchen17
Update on "[jit] Split Tensor type implementations to separate file."
b648d05 
Code move all TensorType dependencies into a separate `tensor_type.cpp`, so that we don't link with it in the min runtime accidentally.

Differential Revision: [D33102286](https://our.internmc.facebook.com/intern/diff/D33102286/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D33102286/)!

[ghstack-poisoned]
@zhxchen17
Update on "[jit] Split Tensor type implementations to separate file."
4bcfafb 
Code move all TensorType dependencies into a separate `tensor_type.cpp`, so that we don't link with it in the min runtime accidentally.

Differential Revision: [D33102286](https://our.internmc.facebook.com/intern/diff/D33102286/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D33102286/)!

[ghstack-poisoned]
@zhxchen17 zhxchen17 mentioned this pull request Dec 29, 2021
Closed
@zhxchen17
Update on "[jit] Split Tensor type implementations to separate file."
8cf6918 
Code move all TensorType dependencies into a separate `tensor_type.cpp`, so that we don't link with it in the min runtime accidentally.

Differential Revision: [D33102286](https://our.internmc.facebook.com/intern/diff/D33102286/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D33102286/)!

[ghstack-poisoned]
@zhxchen17
Update on "[jit] Split Tensor type implementations to separate file."
c2bacd7 
Code move all TensorType dependencies into a separate `tensor_type.cpp`, so that we don't link with it in the min runtime accidentally.

Differential Revision: [D33102286](https://our.internmc.facebook.com/intern/diff/D33102286/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D33102286/)!

[ghstack-poisoned]
@zhxchen17
Update on "[jit] Split Tensor type implementations to separate file."
b44e6d5 
Code move all TensorType dependencies into a separate `tensor_type.cpp`, so that we don't link with it in the min runtime accidentally.

Differential Revision: [D33102286](https://our.internmc.facebook.com/intern/diff/D33102286/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D33102286/)!

[ghstack-poisoned]
@zhxchen17
Update on "[jit] Split Tensor type implementations to separate file."
0499e33 
Code move all TensorType dependencies into a separate `tensor_type.cpp`, so that we don't link with it in the min runtime accidentally.

Differential Revision: [D33102286](https://our.internmc.facebook.com/intern/diff/D33102286/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D33102286/)!

[ghstack-poisoned]
@zhxchen17
Update on "[jit] Split Tensor type implementations to separate file."
96f0e64 
Code move all TensorType dependencies into a separate `tensor_type.cpp`, so that we don't link with it in the min runtime accidentally.

Differential Revision: [D33102286](https://our.internmc.facebook.com/intern/diff/D33102286/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D33102286/)!

[ghstack-poisoned]
@zhxchen17
Update on "[jit] Split Tensor type implementations to separate file."
d3d1e2f 
Code move all TensorType dependencies into a separate `tensor_type.cpp`, so that we don't link with it in the min runtime accidentally.

Differential Revision: [D33102286](https://our.internmc.facebook.com/intern/diff/D33102286/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D33102286/)!

[ghstack-poisoned]
@facebook-github-bot facebook-github-bot deleted the gh/zhxchen17/64/head branch January 11, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmagogsfm gmagogsfm gmagogsfm approved these changes

@Neilblaze Neilblaze Neilblaze approved these changes

@tugsbayasgalan tugsbayasgalan Awaiting requested review from tugsbayasgalan

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhxchen17 @facebook-github-bot @gmagogsfm @Neilblaze
0