8000 [hot fix] Disable MPS tests as machines are down by janeyx99 · Pull Request #79119 · pytorch/pytorch · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[hot fix] Disable MPS tests as machines are down #79119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[hot fix] Disable MPS tests as machines are down #79119

wants to merge 1 commit into from

Conversation

janeyx99
Copy link
Contributor
@janeyx99 janeyx99 commented Jun 8, 2022

@janeyx99 janeyx99 requested a review from a team as a code owner June 8, 2022 11:37
@facebook-github-bot
Copy link
Contributor
facebook-github-bot commented Jun 8, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 4acb5d0 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

atalman
atalman approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor
@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@janeyx99
Copy link
Contributor Author
janeyx99 commented Jun 8, 2022

@pytorchbot merge -f

to unblock trunk

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Contributor
github-actions bot commented Jun 8, 2022

Hey @janeyx99.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@malfet
Copy link
Contributor
malfet commented Jun 8, 2022

@pytorchbot revert -m "Runners are back online" -c weird

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here

pytorchmergebot added a commit that referenced this pull request Jun 8, 2022
@pytorchmergebot
Revert "[hot fix] Disable MPS tests as machines are down (#79119)"
68ef29b 
This reverts commit f2d67c5.

Reverted #79119 on behalf of https://github.com/malfet due to Runners are back online
davidchencsl pushed a commit that referenced this pull request Jun 8, 2022
@janeyx99 @davidchencsl
[hot fix] Disable MPS tests as machines are down (#79119)
6d66192 
Trunk CI is suffering and not running these tests as the runner is unavailable. https://hud.pytorch.org/minihud?name_filter=trunk%20/%20macos-12.3-py3.8-arm64-test%20/%20Run%20MPS%20tests

https://github.com/pytorch/pytorch/runs/6789461040?check_suite_focus=true
Pull Request resolved: #79119
Approved by: https://github.com/atalman
davidchencsl pushed a commit that referenced this pull request Jun 8, 2022
@pytorchmergebot @davidchencsl
Revert "[hot fix] Disable MPS tests as machines are down (#79119)"
b235ff3 
This reverts commit f2d67c5.

Reverted #79119 on behalf of https://github.com/malfet due to Runners are back online
facebook-github-bot pushed a commit that referenced this pull request Jun 8, 2022
@janeyx99 @facebook-github-bot
[hot fix] Disable MPS tests as machines are down (#79119) (#79119)
1af002f 
Summary:
Trunk CI is suffering and not running these tests as the runner is unavailable. https://hud.pytorch.org/minihud?name_filter=trunk%20/%20macos-12.3-py3.8-arm64-test%20/%20Run%20MPS%20tests

https://github.com/pytorch/pytorch/runs/6789461040?check_suite_focus=true

Pull Request resolved: #79119
Approved by: https://github.com/atalman

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/f2d67c547ff0b48c5a6cfa256a7981065fbcf292

Reviewed By: osalpekar

Differential Revision: D37010845

Pulled By: janeyx99

fbshipit-source-id: 81decb0bc4ae0cbd1e43040fdd07bbaece159ec0
facebook-github-bot pushed a commit that referenced this pull request Jun 8, 2022
@pytorchmergebot @facebook-github-bot
Revert "[hot fix] Disable MPS tests as machines are down (#79119)"
df0d70a 
Summary:
This reverts commit f2d67c5.

Reverted #79119 on behalf of https://github.com/malfet due to Runners are back online

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/68ef29b4ca48764a3e8d0ecf25b45c73b9be77e2

Reviewed By: osalpekar

Differential Revision: D37011299

Pulled By: osalpekar

fbshipit-source-id: 4377a825b75c24aa8096a3e1a609cda1d97aa3a1
@janeyx99 janeyx99 mentioned this pull request Jun 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atalman atalman atalman approved these changes

Assignees
No one assigned
Labels
cla signed Merged Reverted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@janeyx99 @facebook-github-bot @pytorchmergebot @malfet @atalman
0