8000 Default on green by zengk95 · Pull Request #78811 · pytorch/pytorch · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Default on green #78811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Default on green #78811

wants to merge 2 commits into from

Conversation

zengk95
Copy link
Contributor
@zengk95 zengk95 commented Jun 3, 2022

Reopens #78771

@zengk95 zengk95 requested a review from a team as a code owner June 3, 2022 14:57
@facebook-github-bot
Copy link
Contributor
facebook-github-bot commented Jun 3, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 273e6bd (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@zengk95
Copy link
Contributor Author
zengk95 commented Jun 3, 2022

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

Merge failed due to Refusing to merge as mandatory check(s) linux-docs / build-docs (cpp), linux-docs / build-docs (python) failed for rule OSS CI
Raised by https://github.com/pytorch/pytorch/actions/runs/2435617164

@zengk95
Copy link
Contributor Author
zengk95 commented Jun 3, 2022

@pytorchbot help

@pytorch-bot
Copy link
pytorch-bot bot commented Jun 3, 2022

PyTorchBot Help

usage: @pytorchbot {merge,revert,rebase,help} ...

command:
  {merge,revert,rebase,help}
    merge               Merge a PR
    revert              Revert a merged PR
    rebase              Rebase a PR
    help                Show help

Merge

usage: @pytorchbot merge [-g] [-a] [-f]

optional arguments:
  -g, --green      Merge when required status checks pass. Currently, we only
                   require lint and builds to pass.
  -a, --all-green  Merge when all status checks pass
  -f, --force      Merge without checking anything. ONLY USE THIS FOR CRITICAL
                   FAILURES.

Revert

usage: @pytorchbot revert -m MESSAGE
                          [-c {nosignal,ignoredsignal,landrace,weird,ghfirst}]

optional arguments:
  -m MESSAGE, --message MESSAGE
                        The reason you are reverting, will be put in the
                        commit message.
  -c {nosignal,ignoredsignal,landrace,weird,ghfirst}, --classification {nosignal,ignoredsignal,landrace,weird,ghfirst}
                        A machine-friendly classification of the revert
                        reason.

Rebase

usage: @pytorchbot rebase [-s]

optional arguments:
  -s, --stable  Rebase to viable/strict

For more info, consult the wiki.

@zengk95
Copy link
Contributor Author
zengk95 commented Jun 3, 2022

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

Successfully rebased default-on-green onto master, please pull locally before adding more changes (for example, via git checkout default-on-green && git pull --rebase)

@zengk95
Copy link
Contributor Author
zengk95 commented Jun 3, 2022

@pytorchbot merge -g

@suo
Copy link
Member
suo commented Jun 3, 2022

We should fast follow with a bot comment that actually tells people what's going on, otherwise people will be confused when @pytorchbot merge doesn't appear to do anything.

For example, on this PR, the contributor used merge -g but then resorted to merge repeatedly because it looked like it didn't do anything: #78801

@lezcano
Copy link
Collaborator
lezcano commented Jun 3, 2022

@suo fwiw, I have no idea what's going on in my PR. Could any of you get it merged? Otherwise, could you give me pointers on what I'm doing wrong?

@github-actions
Copy link
Contributor
github-actions bot commented Jun 3, 2022

Hey @zengk95.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Jun 3, 2022
@zengk95 @facebook-github-bot
Default on green (#78811) (#78811)
99a858f 
Summary:
Reopens #78771

Pull Request resolved: #78811
Approved by: https://github.com/janeyx99

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/c5a0d8dccc63e85ab6590564264b6bb5de43b860

Reviewed By: b0noI

Differential Revision: D36906999

Pulled By: zengk95

fbshipit-source-id: be08db5280109712fdf42de00da714c95b50a72b
@zengk95
Copy link
Contributor Author
zengk95 commented Jun 6, 2022

@pytorchbot revert

@pytorch-bot
Copy link
pytorch-bot bot commented Jun 6, 2022

❌ 🤖 pytorchbot command failed:

@pytorchbot revert: error: the following arguments are required: -m/--message

usage: @pytorchbot revert -m MESSAGE
                          [-c {nosignal,ignoredsignal,landrace,weird,ghfirst}]

Try @pytorchbot help for more info.

@zengk95
Copy link
Contributor Author
zengk95 commented Jun 6, 2022

@pytorchbot revert -m "This does not have force in there" -c weird

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here

pytorchmergebot added a commit that referenced this pull request Jun 6, 2022
@pytorchmergebot
Revert "Default on green (#78811)"
f2b56dd 
This reverts commit c5a0d8d.

Reverted #78811 on behalf of https://github.com/zengk95 due to This does not have force in there
facebook-github-bot pushed a commit that referenced this pull request Jun 7, 2022
@pytorchmergebot @facebook-github-bot
Revert "Default on green (#78811)"
0181b79 
Summary:
This reverts commit c5a0d8d.

Reverted #78811 on behalf of https://github.com/zengk95 due to This does not have force in there

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/f2b56dd6ee8418cba500a79fb759425c97e603f7

Reviewed By: osalpekar

Differential Revision: D36959089

Pulled By: osalpekar

fbshipit-source-id: 03005e44e1becaa9e6761b7ca6aeb554da40c52e
@janeyx99 janeyx99 mentioned this pull request Jun 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janeyx99 janeyx99 janeyx99 approved these changes

Assignees
No one assigned
Labels
cla signed 50CE Merged Reverted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zengk95 @facebook-github-bot @pytorchmergebot @suo @lezcano @janeyx99
0