8000 Retry "[JIT] parse prim::Constant[value=annotate()] and prim::Constant[value={0}]" by davidberard98 · Pull Request #77377 · pytorch/pytorch · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Retry "[JIT] parse prim::Constant[value=annotate()] and prim::Constant[value={0}]" #77377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Retry "[JIT] parse prim::Constant[value=annotate()] and prim::Constant[value={0}]" #77377

wants to merge 1 commit into from

Conversation

davidberard98
Copy link
Contributor
@davidberard98 davidberard98 commented May 12, 2022 •
edited
Loading

Stack from ghstack:

Retry of #76875. It was reverted
due to torchvision failures, but it turned out that the failures were
caused by a different PR.

irparser previously didn't support these, which would cause failures in
log_extract.py

@davidberard98
Retry "[JIT] parse prim::Constant[value=annotate()] and prim::Constan…
4a4691e 
…t[value={0}]"

Retry of #76875. It was reverted
due to torchvision failures, but it turned out that the failures were
caused by a different PR.

irparser previously didn't support these, which would cause failures in
log_extract.py

[ghstack-poisoned]
davidberard98 added a commit that referenced this pull request May 12, 2022
@davidberard98
Retry "[JIT] parse prim::Constant[value=annotate()] and prim::Constan…
8012490 
…t[value={0}]"

Retry of #76875. It was reverted
due to torchvision failures, but it turned out that the failures were
caused by a different PR.

irparser previously didn't support these, which would cause failures in
log_extract.py

ghstack-source-id: b54dce9
Pull Request resolved: #77377
@facebook-github-bot
Copy link
Contributor
facebook-github-bot commented May 12, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (2 Pending)

As of commit 4a4691e (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label May 12, 2022
datumbox
datumbox approved these changes May 13, 2022
View reviewed changes
Copy link
Contributor
@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamping to unblock.

This PR was reverted incorrectly as part of an investigation of a breakage in TorchVision. Apologies for the inconvenience caused to you David.

@davidberard98
Copy link
Contributor Author

@pytorchbot merge this please

@github-actions
Copy link
Contributor

Hey @davidberard98.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@davidberard98 davidberard98 added the topic: not user facing topic category label May 13, 2022
facebook-github-bot pushed a commit that referenced this pull request May 15, 2022
@davidberard98 @facebook-github-bot
Retry "[JIT] parse prim::Constant[value=annotate()] and prim::Constan…
f5e4b0e 
…t[value={0}]" (#77377)

Summary:
Retry of #76875. It was reverted
due to torchvision failures, but it turned out that the failures were
caused by a different PR.

irparser previously didn't support these, which would cause failures in
log_extract.py

Pull Request resolved: #77377

Approved by: https://github.com/datumbox

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/fa44e165ff5f616ae69c0d8dbca757f8d8a9159f

Reviewed By: atalman

Differential Revision: D36386459

Pulled By: davidberard98

fbshipit-source-id: b2ada187e94b8280020f4454e44981f6e45922e9
@facebook-github-bot facebook-github-bot deleted the gh/davidberard98/114/head branch May 17, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datumbox datumbox datumbox approved these changes

@eellison eellison Awaiting requested review from eellison

Assignees
No one assigned
Labels
cla signed Merged oncall: jit Add this issue/PR to JIT oncall triage queue topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidberard98 @facebook-github-bot @datumbox @pytorchmergebot
0