8000 tools: add ability to grab git tag by seemethere · Pull Request #77279 · pytorch/pytorch · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

tools: add ability to grab git tag #77279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

tools: add ability to grab git tag #77279

wants to merge 1 commit into from

Conversation

seemethere
Copy link
Member
@seemethere seemethere commented May 11, 2022 •
edited
Loading

Adds the ability to grab the git tag when using
generate_torch_version.py so that users who build from source on a
specific tag will get the version that they expect.

Behavior is now this:

  1. Check if git tag is available on current commit
  2. If tag available use tagged version, do not attempt to grab other versions
  3. If tag is not available, use previous workflow for determining version

Signed-off-by: Eli Uriegas eliuriegas@fb.com

Fixes #77052

@facebook-github-bot
Copy link
Contributor
facebook-github-bot commented May 11, 2022 •
edited
Loading

🔗 Helpful links

❌ 1 New Failures

As of commit 8ac552c (more details on the Dr. CI page):

Expand to see more
  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages

See GitHub Actions build pull / pytorch-xla-linux-bionic-py3.7-clang8 / test (xla, 1, 1, linux.2xlarge) (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-05-11T20:12:56.7041441Z /var/lib/jenkins/w... virtual member functions can be marked 'override' 
2022-05-11T20:12:56.7038208Z In file included from /var/lib/jenkins/workspace/xla/torch_xla/csrc/aten_xla_bridge.cpp:11:
2022-05-11T20:12:56.7038686Z /var/lib/jenkins/workspace/xla/torch_xla/csrc/tensor_impl.h:33:40: error: only virtual member functions can be marked 'override'
2022-05-11T20:12:56.7039031Z   at::IntArrayRef sizes_custom() const override;
2022-05-11T20:12:56.7039254Z                                        ^~~~~~~~
2022-05-11T20:12:56.7039637Z /var/lib/jenkins/workspace/xla/torch_xla/csrc/tensor_impl.h:34:42: error: only virtual member functions can be marked 'override'
2022-05-11T20:12:56.7039964Z   at::IntArrayRef strides_custom() const override;
2022-05-11T20:12:56.7040187Z                                          ^~~~~~~~
2022-05-11T20:12:56.7040567Z /var/lib/jenkins/workspace/xla/torch_xla/csrc/tensor_impl.h:36:30: error: only virtual member functions can be marked 'override'
2022-05-11T20:12:56.7040869Z   int64_t dim_custom() const override;
2022-05-11T20:12:56.7041063Z                              ^~~~~~~~
2022-05-11T20:12:56.7041441Z /var/lib/jenkins/workspace/xla/torch_xla/csrc/tensor_impl.h:38:32: error: only virtual member functions can be marked 'override'
2022-05-11T20:12:56.7041741Z   int64_t numel_custom() const override;
2022-05-11T20:12:56.7041939Z                                ^~~~~~~~
2022-05-11T20:12:56.7042118Z 4 errors generated.
2022-05-11T20:13:24.1778535Z [9/179] clang++-8 -MMD -MF /var/lib/jenkins/workspace/xla/build/temp.linux-x86_64-3.7/torch_xla/csrc/RegisterXLA.o.d -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -D_GLIBCXX_USE_CXX11_ABI=1 -fPIC -I/var/lib/jenkins/workspace/xla -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-bin -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/protobuf_archive/src -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/com_google_protobuf/src -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/eigen_archive -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/com_google_absl -I/var/lib/jenkins/workspace -I/var/lib/jenkins/workspace/torch/csrc -I/var/lib/jenkins/workspace/torch/lib/tmp_install/include -I/opt/conda/lib/python3.7/site-packages/torch/include -I/opt/conda/lib/python3.7/site-packages/torch/include/torch/csrc/api/include -I/opt/conda/lib/python3.7/site-packages/torch/include/TH -I/opt/conda/lib/python3.7/site-packages/torch/include/THC -I/opt/conda/include/python3.7m -c -c /var/lib/jenkins/workspace/xla/torch_xla/csrc/RegisterXLA.cpp -o /var/lib/jenkins/workspace/xla/build/temp.linux-x86_64-3.7/torch_xla/csrc/RegisterXLA.o -std=c++14 -Wno-sign-compare -Wno-deprecated-declarations -Wno-return-type -Wno-macro-redefined -Wno-return-std-move -DNDEBUG -DTORCH_API_INCLUDE_EXTENSION_H '-DPYBIND11_COMPILER_TYPE="_clang"' '-DPYBIND11_STDLIB="_libstdcpp"' '-DPYBIND11_BUILD_ABI="_cxxabi1002"' -DTORCH_EXTENSION_NAME=_XLAC -D_GLIBCXX_USE_CXX11_ABI=1
2022-05-11T20:13:24.1780862Z /var/lib/jenkins/workspace/xla/torch_xla/csrc/RegisterXLA.cpp:63:6: warning: unused function 'resize_out' [-Wunused-function]
2022-05-11T20:13:24.1781267Z void resize_out(const Tensor &out, IntArrayRef sizes, IntArrayRef strides, const TensorOptions &options) {
2022-05-11T20:13:24.1781514Z      ^
2022-05-11T20:13:24.1782066Z /var/lib/jenkins/workspace/xla/torch_xla/csrc/RegisterXLA.cpp:82:6: warning: unused function 'check_inplace' [-Wunused-function]
2022-05-11T20:13:24.1782451Z void check_inplace(const Tensor &self, IntArrayRef sizes, const TensorOptions &options) {
2022-05-11T20:13:24.1782683Z      ^
This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@seemethere seemethere mentioned this pull request May 11, 2022
Open
@seemethere seemethere marked this pull request as ready for review May 11, 2022 18:27
@seemethere seemethere requested a review from ezyang May 11, 2022 18:36
@seemethere seemethere force-pushed the seemethere/git_tag_in_version branch from a79eeea to a4ab288 Compare May 11, 2022 18:36
@seemethere seemethere requested a review from a team May 11, 2022 18:36
@seemethere
tools: add ability to grab git tag
8ac552c 
Adds the ability to grab the git tag when using
`generate_torch_version.py` so that users who build from source on a
specific tag will get the version that they expect.

Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
@seemethere seemethere force-pushed the seemethere/git_tag_in_version branch from a4ab288 to 8ac552c Compare May 11, 2022 18:38
@seemethere
Copy link
Member Author

@pytorchbot merge this

@github-actions
Copy link
Contributor

Hey @seemethere.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request May 13, 2022
@seemethere @facebook-github-bot
tools: add ability to grab git tag (#77279) (#77279)
22aa30a 
Summary:
Adds the ability to grab the git tag when using
`generate_torch_version.py` so that users who build from source on a
specific tag will get the version that they expect.

Behavior is now this:
1. Check if git tag is available on current commit
2. If tag available use tagged version, do not attempt to grab other versions
3. If tag is not available, use previous workflow for determining version

Signed-off-by: Eli Uriegas <eliuriegas@fb.com>

Fixes #77052

Pull Request resolved: #77279
Approved by: https://github.com/ezyang

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/ba5529650461b869dd0ee5d953a5ce98fb68d847

Reviewed By: atalman

Differential Revision: D36353683

fbshipit-source-id: be59cccdb72b991b7d741eb453d151957700f62a
@seemethere seemethere mentioned this pull request May 13, 2022
Closed
@seemethere
Copy link
Member Author

@pytorchbot revert -m "Broke ciflow related builds, see https://github.com/pytorch/pytorch/runs/6423279105?check_suite_focus=true"

@pytorch-bot
Copy link
pytorch-bot bot commented May 13, 2022

Revert unsuccessful: please retry the command and provide a classification, e.g. @pytorchbot revert -m="this breaks mac tests on trunk" -c="ghfirst".

@seemethere
Copy link
Member Author

@pytorchbot revert -m "Broke ciflow related builds, see pytorch/pytorch/runs/6423279105?check_suite_focus=true" -c "ghfirst"

@pytorchmergebot
Copy link
Collaborator

Reverting PR 77279 failed due to Comment @pytorchbot revert -m "Broke ciflow related builds, see pytorch/pytorch/runs/6423279105?check_suite_focus=true" -c "ghfirst" does not seem to be a valid revert command
Raised by https://github.com/pytorch/pytorch/actions/runs/2321554777

@seemethere
Copy link
Member Author

@pytorchbot revert this, Broke ciflow related builds see https://github.com/pytorch/pytorch/runs/6423279105?check_suite_focus=true

pytorchmergebot added a commit that referenced this pull request May 13, 2022
@pytorchmergebot
Revert "tools: add ability to grab git tag (#77279)"
9728368 
This reverts commit ba55296.

Reverted #77279 on behalf of https://github.com/seemethere
@janeyx99 janeyx99 mentioned this pull request May 18, 2022
Closed
@seemethere seemethere mentioned this pull request May 31, 2022
Closed
@github-actions github-actions bot deleted the seemethere/git_tag_in_version branch February 16, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezyang ezyang ezyang approved these changes

Assignees
No one assigned
Labels
cla signed Merged Reverted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Building from source results in broken __version__
4 participants
@seemethere @facebook-github-bot @pytorchmergebot @ezyang
0