8000 Apply black lint CI to PrimTorch by ezyang · Pull Request #77226 · pytorch/pytorch · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Apply black lint CI to PrimTorch #77226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Apply black lint CI to PrimTorch #77226

wants to merge 2 commits into from

Conversation

ezyang
Copy link
Contributor
@ezyang ezyang commented May 11, 2022 •
edited
Loading

Stack from ghstack (oldest at bottom):

Signed-off-by: Edward Z. Yang ezyang@fb.com

@ezyang
Apply black lint CI to PrimTorch
090eebb 
Signed-off-by: Edward Z. Yang <ezyang@fb.com>

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor
facebook-github-bot commented May 11, 2022 •
edited
Loading

🔗 Helpful links

✅ 2 Base Failures

As of commit cff392c (more details on the Dr. CI page):

Expand to see more

✅ None of the CI failures appear to be your fault 💚

🚧 2 fixed upstream failures:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD
This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

ezyang added a commit that referenced this pull request May 11, 2022
@ezyang
Apply black lint CI to PrimTorch
a98bb22 
Signed-off-by: Edward Z. Yang <ezyangfb.com>

ghstack-source-id: c283237
Pull Request resolved: #77226
@ezyang ezyang requested a review from mruberry May 11, 2022 02:42
mruberry
mruberry approved these changes May 11, 2022
View reviewed changes
Copy link
Collaborator
@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please

@ezyang
Update on "Apply black lint CI to PrimTorch"
cff392c 
Signed-off-by: Edward Z. Yang <ezyangfb.com>

[ghstack-poisoned]
ezyang added a commit that referenced this pull request May 11, 2022
@ezyang
Apply black lint CI to PrimTorch
7130397 
Signed-off-by: Edward Z. Yang <ezyangfb.com>

ghstack-source-id: c36c42e
Pull Request resolved: #77226
@ezyang
Copy link
Contributor Author
ezyang commented May 11, 2022

@pytorchbot merge on green

@ezyang
Copy link
Contributor Author
ezyang commented May 11, 2022

@pytorchbot merge this

@github-actions
Copy link
Contributor

Hey @ezyang.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@ezyang
Copy link
Contributor Author
ezyang commented May 11, 2022

@pytorchbot revert this land race with another one of my PRs

pytorchmergebot added a commit that referenced this pull request May 11, 2022
@pytorchmergebot
Revert "Apply black lint CI to PrimTorch"
bbb1a55 
This reverts commit 188854e.

Reverted #77226 on behalf of https://github.com/ezyang
@ezyang ezyang reopened this May 11, 2022
@ezyang
Copy link
Contributor Author
ezyang commented May 11, 2022

@pytorchbot rebase this

@pytorchmergebot
Copy link
Collaborator

PR #77226 is a ghstack, which is currently not supported

@ezyang
Copy link
Contributor Author
ezyang commented May 11, 2022

@pytorchbot merge this

@pytorchmergebot
Copy link
Collaborator

Merge failed due to Refusing to merge as mandatory check(s) Lint are not yet run for rule superuser
Raised by https://github.com/pytorch/pytorch/actions/runs/2308895888

@ezyang
Copy link
Contributor Author
ezyang commented May 11, 2022

@pytorchbot merge this

@github-actions
Copy link
Contributor

Hey @ezyang.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request May 13, 2022
@ezyang @facebook-github-bot
Apply black lint CI to PrimTorch (#77226)
2bec299 
Summary:
Signed-off-by: Edward Z. Yang <ezyangfb.com>

Pull Request resolved: #77226

Approved by: https://github.com/mruberry

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/188854eeaf148b685e54a438fa7b9a20d3a28e33

Reviewed By: malfet

Differential Revision: D36322624

Pulled By: malfet

fbshipit-source-id: 9ac7f7ae3c25d3581be4717fb0b9acf5f47ae6db
@facebook-github-bot facebook-github-bot deleted the gh/ezyang/1151/head branch May 15, 2022 14:17
@janeyx99 janeyx99 mentioned this pull request May 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mruberry mruberry mruberry approved these changes

Assignees
No one assigned
Labels
cla signed Merged Reverted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ezyang @facebook-github-bot @pytorchmergebot @mruberry
0